Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webrev: do not fetch remote branches #560

Closed
wants to merge 2 commits into from

Conversation

edvbld
Copy link
Member

@edvbld edvbld commented Apr 2, 2020

Hi all,

please review this patch that makes webrev use the branches under remote/
(e.g. origin/) to when calculating the closest remote branch. There is no need
to fetch the remote branches.

Testing:

  • Manual testing of git webrev

Thanks,
Erik


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Reviewers

Download

$ git fetch https://git.openjdk.java.net/skara pull/560/head:pull/560
$ git checkout pull/560

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 2, 2020

👋 Welcome back ehelin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

@mlbridge
Copy link

mlbridge bot commented Apr 2, 2020

Webrevs

Copy link
Member

@rwestberg rwestberg left a comment

Looks good!

@openjdk
Copy link

openjdk bot commented Apr 3, 2020

@edvbld This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

webrev: do not fetch remote branches

Reviewed-by: rwestberg
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /solves command.

Since the source branch of this PR was last updated there have been 5 commits pushed to the master branch. Since there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate 921411f18ace53f7539057bd939b5050474a0dfc.

➡️ To integrate this PR with the above commit message, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Apr 3, 2020
@edvbld
Copy link
Member Author

edvbld commented Apr 3, 2020

/integrate

@openjdk openjdk bot closed this Apr 3, 2020
@openjdk openjdk bot added integrated and removed ready labels Apr 3, 2020
@openjdk
Copy link

openjdk bot commented Apr 3, 2020

@edvbld The following commits have been pushed to master since your change was applied:

  • 921411f: merge-bot: create integrateable pull requests
  • 4da64c8: 352: Set X-Git-URL and X-Git-Changeset headers for push notification emails
  • 46c6d8d: Parse the bidirectional option properly
  • 60a1030: 278: Enhance the /solves command
  • d48c124: Allow disabling bidirectional mailing list syncing per repo

Your commit was automatically rebased without conflicts.

Pushed as commit 629d2f8.

@openjdk openjdk bot removed the rfr label Apr 3, 2020
@mlbridge
Copy link

mlbridge bot commented Apr 3, 2020

Mailing list message from Erik Helin on skara-dev:

Changeset: 629d2f8
Author: Erik Helin <ehelin at openjdk.org>
Date: 2020-04-03 12:52:17 +0000
URL: https://git.openjdk.java.net/skara/commit/629d2f85

webrev: do not fetch remote branches

Reviewed-by: rwestberg

! cli/src/main/java/org/openjdk/skara/cli/GitWebrev.java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants