Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GitLab source_project_id api call #573

Closed
wants to merge 1 commit into from

Conversation

rwestberg
Copy link
Member

@rwestberg rwestberg commented Apr 9, 2020

Hi all,

Please review this small change that fixes a GitLab specific API call.

Best regards,
Robin


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Reviewers

  • Erik Helin (ehelin - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/skara pull/573/head:pull/573
$ git checkout pull/573

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 9, 2020

👋 Welcome back rwestberg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

@openjdk openjdk bot added the rfr label Apr 9, 2020
edvbld
edvbld approved these changes Apr 9, 2020
Copy link
Member

@edvbld edvbld left a comment

Looks good!

@openjdk
Copy link

openjdk bot commented Apr 9, 2020

@rwestberg This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

Fix GitLab source_project_id api call

Reviewed-by: ehelin
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /solves command.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Apr 9, 2020
@rwestberg
Copy link
Member Author

rwestberg commented Apr 9, 2020

/integrate

@openjdk openjdk bot closed this Apr 9, 2020
@openjdk openjdk bot added integrated and removed ready labels Apr 9, 2020
@openjdk
Copy link

openjdk bot commented Apr 9, 2020

@rwestberg
Pushed as commit e922c1d.

@openjdk openjdk bot removed the rfr label Apr 9, 2020
@mlbridge
Copy link

mlbridge bot commented Apr 9, 2020

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants