New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use proper value for GitLab PR state #576
Conversation
|
/integrate |
@rwestberg Your merge request cannot be fulfilled at this time, as your changes failed the final jcheck:
|
@rwestberg This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type
|
/integrate |
@rwestberg |
Mailing list message from Robin Westberg on skara-dev: Changeset: ea3bc91 Use proper value for GitLab PR state Reviewed-by: duke, ehelin ! forge/src/main/java/org/openjdk/skara/forge/gitlab/GitLabMergeRequest.java |
Mailing list message from Magnus Ihse Bursie on skara-dev: I'm a bit curious -- how come our Duke is now reviewing PRs? Is this the /Magnus On 2020-04-09 16:36, J.Duke wrote:
|
Mailing list message from Erik Helin on skara-dev: On 4/14/20 9:48 AM, Magnus Ihse Bursie wrote:
Haha, that was me by mistake using the bot account when looking at a PR :) Thanks,
|
Hi all,
Please review this change that properly parses the state of a GitLab PR.
Best regards,
Robin
Progress
Reviewers
Download
$ git fetch https://git.openjdk.java.net/skara pull/576/head:pull/576
$ git checkout pull/576