Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use proper value for GitLab PR state #576

Closed
wants to merge 1 commit into from

Conversation

rwestberg
Copy link
Member

@rwestberg rwestberg commented Apr 9, 2020

Hi all,

Please review this change that properly parses the state of a GitLab PR.

Best regards,
Robin


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Reviewers

  • J. Duke (duke - no project role)
  • Erik Helin (ehelin - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/skara pull/576/head:pull/576
$ git checkout pull/576

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 9, 2020

👋 Welcome back rwestberg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

@openjdk openjdk bot added the rfr label Apr 9, 2020
Copy link

@openjdk-bot openjdk-bot left a comment

Looks good!

@mlbridge
Copy link

mlbridge bot commented Apr 9, 2020

Webrevs

@rwestberg
Copy link
Member Author

rwestberg commented Apr 9, 2020

/integrate

@openjdk
Copy link

openjdk bot commented Apr 9, 2020

@rwestberg Your merge request cannot be fulfilled at this time, as your changes failed the final jcheck:

  • Too few reviewers with at least role reviewer found (have 0, need at least 1)

edvbld
edvbld approved these changes Apr 9, 2020
Copy link
Member

@edvbld edvbld left a comment

Looks good!

@openjdk
Copy link

openjdk bot commented Apr 9, 2020

@rwestberg This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

Use proper value for GitLab PR state

Reviewed-by: duke, ehelin
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /solves command.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Apr 9, 2020
@rwestberg
Copy link
Member Author

rwestberg commented Apr 14, 2020

/integrate

@openjdk openjdk bot closed this Apr 14, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Apr 14, 2020
@openjdk
Copy link

openjdk bot commented Apr 14, 2020

@rwestberg
Pushed as commit ea3bc91.

@mlbridge
Copy link

mlbridge bot commented Apr 14, 2020

Mailing list message from Robin Westberg on skara-dev:

Changeset: ea3bc91
Author: Robin Westberg <rwestberg at openjdk.org>
Date: 2020-04-14 04:22:19 +0000
URL: https://git.openjdk.java.net/skara/commit/ea3bc918

Use proper value for GitLab PR state

Reviewed-by: duke, ehelin

! forge/src/main/java/org/openjdk/skara/forge/gitlab/GitLabMergeRequest.java

@mlbridge
Copy link

mlbridge bot commented Apr 14, 2020

Mailing list message from Magnus Ihse Bursie on skara-dev:

I'm a bit curious -- how come our Duke is now reviewing PRs? Is this the
result of some bot verifying the patch? Or just a mistake due to someone
logged in with the wrong account?

/Magnus

On 2020-04-09 16:36, J.Duke wrote:

On Thu, 9 Apr 2020 14:29:16 GMT, Robin Westberg <rwestberg at openjdk.org> wrote:

Hi all,

Please review this change that properly parses the state of a GitLab PR.

Best regards,
Robin
Looks good!

-------------

Marked as reviewed by duke (no project role).

PR: https://git.openjdk.java.net/skara/pull/576

@mlbridge
Copy link

mlbridge bot commented Apr 14, 2020

Mailing list message from Erik Helin on skara-dev:

On 4/14/20 9:48 AM, Magnus Ihse Bursie wrote:

I'm a bit curious -- how come our Duke is now reviewing PRs? Is this the
result of some bot verifying the patch? Or just a mistake due to someone
logged in with the wrong account?

Haha, that was me by mistake using the bot account when looking at a PR :)

Thanks,
Erik

/Magnus

On 2020-04-09 16:36, J.Duke wrote:

On Thu, 9 Apr 2020 14:29:16 GMT, Robin Westberg
<rwestberg at openjdk.org> wrote:

Hi all,

Please review this change that properly parses the state of a GitLab PR.

Best regards,
Robin
Looks good!

-------------

Marked as reviewed by duke (no project role).

PR: https://git.openjdk.java.net/skara/pull/576

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants