Use proper value for GitLab PR state

[rwestberg]

Hi all,

Please review this change that properly parses the state of a GitLab PR.

Best regards,
Robin

---

Progress

• Change must not contain extraneous whitespace
• Change must be properly reviewed

Reviewers

• J. Duke (duke - no project role)
• Erik Helin (ehelin - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/skara pull/576/head:pull/576
$ git checkout pull/576

[bridgekeeper]

👋 Welcome back rwestberg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

[openjdk-bot]

Looks good!

[mlbridge]

Webrevs

• 00: Full (d20726b)

[rwestberg]

/integrate

[openjdk]

@rwestberg Your merge request cannot be fulfilled at this time, as your changes failed the final jcheck:

• Too few reviewers with at least role reviewer found (have 0, need at least 1)

[edvbld]

Looks good!

[openjdk]

@rwestberg This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

Use proper value for GitLab PR state

Reviewed-by: duke, ehelin

• If you would like to add a summary, use the /summary command.
• To credit additional contributors, use the /contributor command.
• To add additional solved issues, use the /solves command.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[rwestberg]

/integrate

[openjdk]

@rwestberg
Pushed as commit ea3bc91.

[mlbridge]

Mailing list message from Robin Westberg on skara-dev:

Changeset: ea3bc91
Author: Robin Westberg <rwestberg at openjdk.org>
Date: 2020-04-14 04:22:19 +0000
URL: https://git.openjdk.java.net/skara/commit/ea3bc918

Use proper value for GitLab PR state

Reviewed-by: duke, ehelin

! forge/src/main/java/org/openjdk/skara/forge/gitlab/GitLabMergeRequest.java

[mlbridge]

Mailing list message from Magnus Ihse Bursie on skara-dev:

I'm a bit curious -- how come our Duke is now reviewing PRs? Is this the
result of some bot verifying the patch? Or just a mistake due to someone
logged in with the wrong account?

/Magnus

On 2020-04-09 16:36, J.Duke wrote:

On Thu, 9 Apr 2020 14:29:16 GMT, Robin Westberg <rwestberg at openjdk.org> wrote:

Hi all,

Please review this change that properly parses the state of a GitLab PR.

Best regards,
Robin
Looks good!

-------------

Marked as reviewed by duke (no project role).

PR: https://git.openjdk.java.net/skara/pull/576

[mlbridge]

Mailing list message from Erik Helin on skara-dev:

On 4/14/20 9:48 AM, Magnus Ihse Bursie wrote:

I'm a bit curious -- how come our Duke is now reviewing PRs? Is this the
result of some bot verifying the patch? Or just a mistake due to someone
logged in with the wrong account?

Haha, that was me by mistake using the bot account when looking at a PR :)

Thanks,
Erik

/Magnus

On 2020-04-09 16:36, J.Duke wrote:

On Thu, 9 Apr 2020 14:29:16 GMT, Robin Westberg
<rwestberg at openjdk.org> wrote:

Hi all,

Please review this change that properly parses the state of a GitLab PR.

Best regards,
Robin
Looks good!

-------------

Marked as reviewed by duke (no project role).

PR: https://git.openjdk.java.net/skara/pull/576