Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge-bot: use commitMetadata when listing commits #578

wants to merge 1 commit into from
Changes from all commits
File filter

Filter by extension

Filter by extension

Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
@@ -463,7 +463,7 @@ public void run(Path scratchPath) {
message.add("<!-- " + fetchHead.hex() + " -->");

var commits = repo.commits(mergeBase.hex() + ".." + fetchHead.hex(), true).asList();
var commits = repo.commitMetadata(mergeBase.hex() + ".." + fetchHead.hex(), true);
Copy link

@rwestberg rwestberg Apr 15, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use the overloaded range syntax instead of manual ".."?

var numCommits = commits.size();
var are = numCommits > 1 ? "are" : "is";
var s = numCommits > 1 ? "s" : "";