Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: respect git's http.proxy setting #586

Closed
wants to merge 3 commits into from

Conversation

edvbld
Copy link
Member

@edvbld edvbld commented Apr 16, 2020

Hi all,

please review this small patch that makes the gradlew script respect git's
http.proxy setting.

Testing:

  • Manual testing of sh gradlew

Thanks,
Erik


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Reviewers

Download

$ git fetch https://git.openjdk.java.net/skara pull/586/head:pull/586
$ git checkout pull/586

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Apr 16, 2020

👋 Welcome back ehelin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Apr 16, 2020

Webrevs

Copy link
Member

@rwestberg rwestberg left a comment

Looks good!

@openjdk
Copy link

@openjdk openjdk bot commented Apr 16, 2020

@edvbld This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

build: respect git's http.proxy setting

Reviewed-by: rwestberg
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /solves command.

Since the source branch of this PR was last updated there has been 1 commit pushed to the master branch. As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate b60f393c557840d8960327cd15ee3e11fe363734.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Apr 16, 2020
Copy link
Member

@rwestberg rwestberg left a comment

Actually, looks like it doesn't build. :)

@openjdk openjdk bot removed the ready label Apr 16, 2020
@edvbld
Copy link
Member Author

@edvbld edvbld commented Apr 17, 2020

@rwestberg now it builds! 😃

Copy link
Member

@rwestberg rwestberg left a comment

Great!

@openjdk openjdk bot added the ready label Apr 17, 2020
@edvbld
Copy link
Member Author

@edvbld edvbld commented Apr 17, 2020

/integrate

@openjdk openjdk bot closed this Apr 17, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Apr 17, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Apr 17, 2020

@edvbld The following commits have been pushed to master since your change was applied:

  • b60f393: skara: add aliases for publish and proxy

Your commit was automatically rebased without conflicts.

Pushed as commit ec3635c.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Apr 17, 2020

Mailing list message from Erik Helin on skara-dev:

Changeset: ec3635c
Author: Erik Helin <ehelin at openjdk.org>
Date: 2020-04-17 09:43:20 +0000
URL: https://git.openjdk.java.net/skara/commit/ec3635cb

build: respect git's http.proxy setting

Reviewed-by: rwestberg

! gradlew

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants