Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement HgRepository::amend #59

Closed
wants to merge 1 commit into from
Closed

Implement HgRepository::amend #59

wants to merge 1 commit into from

Conversation

@edvbld
Copy link
Member

edvbld commented Aug 19, 2019

Hi all,

this patch implements the HgRepository::amend method. I also added a test that tests amend for both git and hg.

Testing

  • sh gradlew test passes on
    • Linux
    • Windows
    • macOS

Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Approvers

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 19, 2019

👋 Welcome back ehelin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request (refresh this page to view it).

@openjdk openjdk bot added the rfr label Aug 19, 2019
@mlbridge
Copy link

mlbridge bot commented Aug 19, 2019

Webrevs

@rwestberg
Copy link
Member

rwestberg commented Aug 19, 2019

Looks good!

@edvbld
Copy link
Member Author

edvbld commented Aug 19, 2019

/integrate

@openjdk
Copy link

openjdk bot commented Aug 19, 2019

@edvbld Your merge request cannot be fulfilled at this time, as the status check jcheck did not complete successfully

@openjdk openjdk bot removed the rfr label Aug 19, 2019
@openjdk
Copy link

openjdk bot commented Aug 19, 2019

@edvbld This change can now be integrated. The commit message will be:

Implement HgRepository::amend

Reviewed-by: rwestberg
  • If you would like to add a summary, use the /summary command.
  • To list additional contributors, use the /contributor command.
  • To integrate this PR with the above commit message, type /integrate in a new comment.
@openjdk openjdk bot added the ready label Aug 19, 2019
@edvbld
Copy link
Member Author

edvbld commented Aug 19, 2019

/integrate

@openjdk openjdk bot closed this Aug 19, 2019
@openjdk
Copy link

openjdk bot commented Aug 19, 2019

@edvbld Pushed as commit 7623f82.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.