Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid setting ignoreFailures for the test report #601

Closed
wants to merge 4 commits into from

Conversation

rwestberg
Copy link
Member

@rwestberg rwestberg commented Apr 24, 2020

Hi all,

Please review this change that drops the logic for setting ignoreFailures when building the testReport target, as this doesn't work properly, and currently hides failures in CI.

Best regards,
Robin


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Reviewers

  • Erik Helin (ehelin - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/skara pull/601/head:pull/601
$ git checkout pull/601

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 24, 2020

👋 Welcome back rwestberg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

@mlbridge
Copy link

mlbridge bot commented Apr 24, 2020

Webrevs

@openjdk openjdk bot added bots and removed rfr labels Apr 24, 2020
@openjdk openjdk bot added the rfr label Apr 24, 2020
edvbld
edvbld approved these changes Apr 24, 2020
Copy link
Member

@edvbld edvbld left a comment

Looks good, thanks for fixing!

@openjdk
Copy link

openjdk bot commented Apr 24, 2020

@rwestberg This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

Avoid setting ignoreFailures for the test report

Reviewed-by: ehelin
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /solves command.

Since the source branch of this PR was last updated there have been 2 commits pushed to the master branch. As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate 2dca7b7f4b0cece53525e69a2de6792b016e5e11.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Apr 24, 2020
@rwestberg
Copy link
Member Author

rwestberg commented Apr 24, 2020

/integrate

@openjdk openjdk bot closed this Apr 24, 2020
@openjdk openjdk bot added integrated and removed ready labels Apr 24, 2020
@openjdk
Copy link

openjdk bot commented Apr 24, 2020

@rwestberg The following commits have been pushed to master since your change was applied:

  • 2dca7b7: merge-bot: allow specs to define dependencies
  • 8d9b6e9: cli: add trees command

Your commit was automatically rebased without conflicts.

Pushed as commit 75f257e.

@openjdk openjdk bot removed the rfr label Apr 24, 2020
@mlbridge
Copy link

mlbridge bot commented Apr 24, 2020

Mailing list message from Robin Westberg on skara-dev:

Changeset: 75f257e
Author: Robin Westberg <rwestberg at openjdk.org>
Date: 2020-04-24 14:16:22 +0000
URL: https://git.openjdk.java.net/skara/commit/75f257ef

Avoid setting ignoreFailures for the test report

Reviewed-by: ehelin

! bots/merge/src/test/java/org/openjdk/skara/bots/merge/MergeBotTests.java
! bots/mlbridge/src/test/java/org/openjdk/skara/bots/mlbridge/MailingListBridgeBotTests.java
! build.gradle

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants