Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

365: Allows "merge style" PRs to have title of "Merge repo:tag" #610

Closed
wants to merge 1 commit into from

Conversation

rwestberg
Copy link
Member

@rwestberg rwestberg commented Apr 28, 2020

Hi all,

Please review this change that improves the merge sourcing for merge PRs and allows tags to be used as a source.

Best regards,
Robin


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Issue

  • SKARA-365: Allows "merge style" PRs to have title of "Merge repo:tag"

Reviewers

  • Erik Helin (ehelin - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/skara pull/610/head:pull/610
$ git checkout pull/610

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 28, 2020

👋 Welcome back rwestberg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

edvbld
edvbld approved these changes Apr 28, 2020
Copy link
Member

@edvbld edvbld left a comment

Very nice patch, looks great! 👏

@openjdk
Copy link

openjdk bot commented Apr 28, 2020

@rwestberg This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

365: Allows "merge style" PRs to have title of "Merge repo:tag"

Reviewed-by: ehelin
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /solves command.

There are currently no new commits on the master branch since the last update of the source branch of this PR. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you would like to avoid potential automatic rebasing, specify the current head hash when integrating, like this: /integrate b2ea62e5573753a8b04ba92769c7f8a83182cd76.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Apr 28, 2020
@mlbridge
Copy link

mlbridge bot commented Apr 28, 2020

Webrevs

@rwestberg
Copy link
Member Author

rwestberg commented Apr 28, 2020

/integrate

@openjdk openjdk bot closed this Apr 28, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Apr 28, 2020
@openjdk
Copy link

openjdk bot commented Apr 28, 2020

@rwestberg
Pushed as commit 572b1c4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants