Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: update to Gradle 6.3 #614

Closed
wants to merge 1 commit into from
Closed

Conversation

edvbld
Copy link
Member

@edvbld edvbld commented Apr 29, 2020

Hi all,

please review this patch that updates Gradle to version 6.3.

Testing:

  • sh gradlew images
  • sh gradlew test

Thanks,
Erik


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Reviewers

Download

$ git fetch https://git.openjdk.java.net/skara pull/614/head:pull/614
$ git checkout pull/614

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Apr 29, 2020

👋 Welcome back ehelin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

Copy link
Member

@rwestberg rwestberg left a comment

Looks good!

@openjdk
Copy link

@openjdk openjdk bot commented Apr 29, 2020

@edvbld This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

build: update to Gradle 6.3

Reviewed-by: rwestberg
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /solves command.

There are currently no new commits on the master branch since the last update of the source branch of this PR. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you would like to avoid potential automatic rebasing, specify the current head hash when integrating, like this: /integrate ad1bc216306da476cb9597360ae4078b5d0266d3.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Apr 29, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Apr 29, 2020

Webrevs

@edvbld
Copy link
Member Author

@edvbld edvbld commented Apr 29, 2020

/integrate

@openjdk openjdk bot closed this Apr 29, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Apr 29, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Apr 29, 2020

@edvbld
Pushed as commit 25e653d.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants