Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

384: Suggest issue command instead of solves command #616

Closed
wants to merge 1 commit into from

Conversation

rwestberg
Copy link
Member

@rwestberg rwestberg commented May 4, 2020

Hi all,

Please review this minor change that suggest the issue command instead of solves.

Best regards,
Robin


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Issue

  • SKARA-384: Suggest issue command instead of solves command

Reviewers

Download

$ git fetch https://git.openjdk.java.net/skara pull/616/head:pull/616
$ git checkout pull/616

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented May 4, 2020

👋 Welcome back rwestberg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

@mlbridge
Copy link

@mlbridge mlbridge bot commented May 4, 2020

Webrevs

@openjdk
Copy link

@openjdk openjdk bot commented May 7, 2020

@rwestberg This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

384: Suggest issue command instead of solves command

Reviewed-by: jvernee
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /solves command.

There are currently no new commits on the master branch since the last update of the source branch of this PR. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you would like to avoid potential automatic rebasing, specify the current head hash when integrating, like this: /integrate b63ea1c968486a159a924473f94f0d751bba4854.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label May 7, 2020
@rwestberg
Copy link
Member Author

@rwestberg rwestberg commented May 8, 2020

/integrate

@openjdk openjdk bot closed this May 8, 2020
@openjdk openjdk bot added the integrated label May 8, 2020
@openjdk
Copy link

@openjdk openjdk bot commented May 8, 2020

@rwestberg
Pushed as commit c967e0a.

@openjdk openjdk bot removed ready rfr labels May 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants