Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

396: Add some additional help for empty PRs #621

Closed
wants to merge 1 commit into from

Conversation

@rwestberg
Copy link
Member

@rwestberg rwestberg commented May 11, 2020

Hi all,

Please review this change that adds a placeholder message that can help the user to determine how exactly the "empty PR body" error should be remedied.

Best regards,
Robin


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Issue

  • SKARA-396: Add some additional help for empty PRs

Reviewers

Download

$ git fetch https://git.openjdk.java.net/skara pull/621/head:pull/621
$ git checkout pull/621

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented May 11, 2020

👋 Welcome back rwestberg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

@mlbridge
Copy link

@mlbridge mlbridge bot commented May 11, 2020

Webrevs

@openjdk
Copy link

@openjdk openjdk bot commented May 11, 2020

@rwestberg This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

396: Add some additional help for empty PRs

Reviewed-by: jvernee
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /solves command.

Since the source branch of this PR was last updated there have been 2 commits pushed to the master branch:

  • c558479: 397: Extend the additional errors section with hidden jcheck entries
  • 6b6952e: 398: git webrev cannot handle a file named index.html

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate c558479555ec8f87360c2bab365191ee498751aa.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label May 11, 2020
@rwestberg
Copy link
Member Author

@rwestberg rwestberg commented May 11, 2020

/integrate

@openjdk openjdk bot closed this May 11, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels May 11, 2020
@openjdk
Copy link

@openjdk openjdk bot commented May 11, 2020

@rwestberg The following commits have been pushed to master since your change was applied:

  • c558479: 397: Extend the additional errors section with hidden jcheck entries
  • 6b6952e: 398: git webrev cannot handle a file named index.html

Your commit was automatically rebased without conflicts.

Pushed as commit 052aee4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants