Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

383: More fuzzy matching of bug ids in PR titles #623

Closed
wants to merge 2 commits into from

Conversation

@rwestberg
Copy link
Member

@rwestberg rwestberg commented May 13, 2020

Hi all,

Please review this change that allows a more relaxed matching of bug ids in PR titles. Also contains a bit of refactoring to make it explicit when the project name could be part of the bug id. There were several places that expected the project name to not be present (as they would fetch the issue using the key from a specific project) - these now explicitly use the shortId.

Best regards,
Robin


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Issue

  • SKARA-383: More fuzzy matching of bug ids in PR titles

Reviewers

Download

$ git fetch https://git.openjdk.java.net/skara pull/623/head:pull/623
$ git checkout pull/623

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented May 13, 2020

👋 Welcome back rwestberg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

@mlbridge
Copy link

@mlbridge mlbridge bot commented May 13, 2020

Webrevs

Copy link
Member

@JornVernee JornVernee left a comment

LGTM. One minor comment.

public int hashCode() {
return Objects.hash(id, description);
public String toShortString() {
return id + ": " + description;
Copy link
Member

@JornVernee JornVernee May 14, 2020

Bit confusing here when also looking at the toString method impl. Maybe you should rename the id field to shortId now? (to match the method names)

Copy link
Member Author

@rwestberg rwestberg May 14, 2020

Makes sense, will change it.. There's probably a better name than shortId waiting to be discovered out there, but I didn't find it..

@openjdk
Copy link

@openjdk openjdk bot commented May 14, 2020

@rwestberg This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

383: More fuzzy matching of bug ids in PR titles

Reviewed-by: jvernee
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /solves command.

There are currently no new commits on the master branch since the last update of the source branch of this PR. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you would like to avoid potential automatic rebasing, specify the current head hash when integrating, like this: /integrate ec124944f50d141214adfe8e582346ce746a4905.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label May 14, 2020
@rwestberg
Copy link
Member Author

@rwestberg rwestberg commented May 14, 2020

/integrate

@openjdk openjdk bot closed this May 14, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels May 14, 2020
@openjdk
Copy link

@openjdk openjdk bot commented May 14, 2020

@rwestberg
Pushed as commit d1c1a50.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants