New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
383: More fuzzy matching of bug ids in PR titles #623
Conversation
|
Webrevs
|
public int hashCode() { | ||
return Objects.hash(id, description); | ||
public String toShortString() { | ||
return id + ": " + description; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bit confusing here when also looking at the toString method impl. Maybe you should rename the id
field to shortId
now? (to match the method names)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense, will change it.. There's probably a better name than shortId
waiting to be discovered out there, but I didn't find it..
@rwestberg This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type
There are currently no new commits on the
|
/integrate |
@rwestberg |
Hi all,
Please review this change that allows a more relaxed matching of bug ids in PR titles. Also contains a bit of refactoring to make it explicit when the project name could be part of the bug id. There were several places that expected the project name to not be present (as they would fetch the issue using the key from a specific project) - these now explicitly use the shortId.
Best regards,
Robin
Progress
Issue
Reviewers
Download
$ git fetch https://git.openjdk.java.net/skara pull/623/head:pull/623
$ git checkout pull/623