383: More fuzzy matching of bug ids in PR titles

[rwestberg]

Hi all,

Please review this change that allows a more relaxed matching of bug ids in PR titles. Also contains a bit of refactoring to make it explicit when the project name could be part of the bug id. There were several places that expected the project name to not be present (as they would fetch the issue using the key from a specific project) - these now explicitly use the shortId.

Best regards,
Robin

---

Progress

• Change must not contain extraneous whitespace
• Change must be properly reviewed

Issue

• SKARA-383: More fuzzy matching of bug ids in PR titles

Reviewers

• Jorn Vernee (jvernee - Reviewer) ⚠️ Review applies to bc885eb

Download

$ git fetch https://git.openjdk.java.net/skara pull/623/head:pull/623
$ git checkout pull/623

[bridgekeeper]

👋 Welcome back rwestberg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

[mlbridge]

Webrevs

• 01: Full - Incremental (c9515f6)
• 00: Full (bc885eb)

[JornVernee]

LGTM. One minor comment.

[JornVernee]

Bit confusing here when also looking at the toString method impl. Maybe you should rename the id field to shortId now? (to match the method names)

[rwestberg]

Makes sense, will change it.. There's probably a better name than shortId waiting to be discovered out there, but I didn't find it..

[openjdk]

@rwestberg This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

383: More fuzzy matching of bug ids in PR titles

Reviewed-by: jvernee

• If you would like to add a summary, use the /summary command.
• To credit additional contributors, use the /contributor command.
• To add additional solved issues, use the /solves command.

There are currently no new commits on the master branch since the last update of the source branch of this PR. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you would like to avoid potential automatic rebasing, specify the current head hash when integrating, like this: /integrate ec124944f50d141214adfe8e582346ce746a4905.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[rwestberg]

/integrate

[openjdk]

@rwestberg
Pushed as commit d1c1a50.