Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cli] fix typo in GitPrHelp #627

Closed
wants to merge 1 commit into from
Closed

[cli] fix typo in GitPrHelp #627

wants to merge 1 commit into from

Conversation

iignatev
Copy link
Member

@iignatev iignatev commented May 22, 2020

a trivial patch to fix a typo in GitPrHelp (s/requeqsts/requests)


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Reviewers

Download

$ git fetch https://git.openjdk.java.net/skara pull/627/head:pull/627
$ git checkout pull/627

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented May 25, 2020

👋 Welcome back iignatyev! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

@mlbridge
Copy link

@mlbridge mlbridge bot commented May 25, 2020

Webrevs

Copy link
Member

@rwestberg rwestberg left a comment

Looks good, thanks for fixing!

@openjdk
Copy link

@openjdk openjdk bot commented May 25, 2020

@iignatev This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

[cli] fix typo in GitPrHelp

Reviewed-by: rwestberg
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

There are currently no new commits on the master branch since the last update of the source branch of this PR. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you would like to avoid potential automatic rebasing, specify the current head hash when integrating, like this: /integrate a0340ac5221e72655f391ac20ca847038b353113.

As you do not have Committer status in this project, an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@rwestberg) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready label May 25, 2020
@iignatev
Copy link
Member Author

@iignatev iignatev commented May 25, 2020

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented May 25, 2020

@iignatev
Your change (at version 141e968) is now ready to be sponsored by a Committer.

@openjdk openjdk bot added the sponsor label May 25, 2020
@iignatev
Copy link
Member Author

@iignatev iignatev commented May 25, 2020

Thanks, @rwestberg.

@rwestberg
Copy link
Member

@rwestberg rwestberg commented May 26, 2020

/sponsor

@openjdk openjdk bot closed this May 26, 2020
@openjdk
Copy link

@openjdk openjdk bot commented May 26, 2020

@rwestberg @iignatev
Pushed as commit c95cf5a.

@openjdk openjdk bot removed the rfr label May 26, 2020
@iignatev iignatev deleted the fix-typo branch May 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants