Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

402: Properly parse issue titles starting with non-alphanumeric characters #628

Closed
wants to merge 2 commits into from

Conversation

rwestberg
Copy link
Member

@rwestberg rwestberg commented May 25, 2020

Hi all,

Please review this change that properly parses issue titles starting with a non-alphanumeric character.

Best regards,
Robin


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Issue

  • SKARA-402: Properly parse issue titles starting with non-alphanumeric characters

Reviewers

Download

$ git fetch https://git.openjdk.java.net/skara pull/628/head:pull/628
$ git checkout pull/628

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented May 25, 2020

👋 Welcome back rwestberg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

@openjdk openjdk bot added the rfr label May 25, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented May 25, 2020

Webrevs

Copy link
Member

@JornVernee JornVernee left a comment

LGTM!

vcs/src/main/java/org/openjdk/skara/vcs/openjdk/Issue.java Outdated Show resolved Hide resolved
@openjdk
Copy link

@openjdk openjdk bot commented May 25, 2020

@rwestberg This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

402: Properly parse issue titles starting with non-alphanumeric characters

Reviewed-by: jvernee
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

Since the source branch of this PR was last updated there has been 1 commit pushed to the master branch:

  • c95cf5a: [cli] fix typo in GitPrHelp

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate c95cf5afcfe8e126f9514a874336273203b3f031.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label May 25, 2020
Co-authored-by: Jorn Vernee <JornVernee@users.noreply.github.com>
@rwestberg
Copy link
Member Author

@rwestberg rwestberg commented May 26, 2020

/integrate

@openjdk openjdk bot closed this May 26, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels May 26, 2020
@openjdk
Copy link

@openjdk openjdk bot commented May 26, 2020

@rwestberg The following commits have been pushed to master since your change was applied:

  • c95cf5a: [cli] fix typo in GitPrHelp

Your commit was automatically rebased without conflicts.

Pushed as commit 96f7573.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants