Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

403: Allow openjdk-import to update an existing conversion #629

Closed
wants to merge 1 commit into from

Conversation

rwestberg
Copy link
Member

@rwestberg rwestberg commented May 26, 2020

Hi all,

Please review this change that allows the CLI command openjdk-import to update an existing conversion by simply running the same command again.

Best regards,
Robin


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Issue

  • SKARA-403: Allow openjdk-import to update an existing conversion

Reviewers

Download

$ git fetch https://git.openjdk.java.net/skara pull/629/head:pull/629
$ git checkout pull/629

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented May 26, 2020

👋 Welcome back rwestberg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

@mlbridge
Copy link

@mlbridge mlbridge bot commented May 26, 2020

Webrevs

@openjdk
Copy link

@openjdk openjdk bot commented May 26, 2020

@rwestberg This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

403: Allow openjdk-import to update an existing conversion

Reviewed-by: jvernee
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

Since the source branch of this PR was last updated there have been 2 commits pushed to the master branch:

  • 96f7573: 402: Properly parse issue titles starting with non-alphanumeric characters
  • c95cf5a: [cli] fix typo in GitPrHelp

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate 96f757338c26a8a8b9a4f1d1d91dadd4d30804b6.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label May 26, 2020
@rwestberg
Copy link
Member Author

@rwestberg rwestberg commented May 26, 2020

/integrate

@openjdk openjdk bot closed this May 26, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels May 26, 2020
@openjdk
Copy link

@openjdk openjdk bot commented May 26, 2020

@rwestberg The following commits have been pushed to master since your change was applied:

  • 96f7573: 402: Properly parse issue titles starting with non-alphanumeric characters
  • c95cf5a: [cli] fix typo in GitPrHelp

Your commit was automatically rebased without conflicts.

Pushed as commit b03e442.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants