Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

404: Add a blank line after quoted blocks in TextToMarkdown #632

Closed
wants to merge 1 commit into from

Conversation

rwestberg
Copy link
Member

@rwestberg rwestberg commented May 28, 2020

Hi all,

Please review this change that inserts an blank line after quoted blocks in case there isn't one already, which matches how an email client would render the text.

Best regards,
Robin


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Issue

  • SKARA-404: Add a blank line after quoted blocks in TextToMarkdown

Reviewers

Download

$ git fetch https://git.openjdk.java.net/skara pull/632/head:pull/632
$ git checkout pull/632

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented May 28, 2020

👋 Welcome back rwestberg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

@mlbridge
Copy link

@mlbridge mlbridge bot commented May 28, 2020

Webrevs

@openjdk
Copy link

@openjdk openjdk bot commented May 29, 2020

@rwestberg This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

404: Add a blank line after quoted blocks in TextToMarkdown

Reviewed-by: jvernee
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

Since the source branch of this PR was last updated there has been 1 commit pushed to the master branch:

  • 417adeb: Separate the various notifiers into their own packages

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate 417adeb2e8c1c7252dd7946cf4cb58b10d665d45.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label May 29, 2020
@rwestberg
Copy link
Member Author

@rwestberg rwestberg commented Jun 1, 2020

/integrate

@openjdk openjdk bot closed this Jun 1, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Jun 1, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Jun 1, 2020

@rwestberg The following commits have been pushed to master since your change was applied:

  • 417adeb: Separate the various notifiers into their own packages

Your commit was automatically rebased without conflicts.

Pushed as commit f4d9b6e.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants