Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle empty GitLab merge requests #633

Closed
wants to merge 1 commit into from

Conversation

rwestberg
Copy link
Member

@rwestberg rwestberg commented Jun 1, 2020

Hi all,

Please review this small change that allows empty GitLab merge requests to be inspected.

Best regards,
Robin


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Reviewers

  • Erik Helin (ehelin - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/skara pull/633/head:pull/633
$ git checkout pull/633

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 1, 2020

👋 Welcome back rwestberg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

@openjdk openjdk bot added the rfr label Jun 1, 2020
@mlbridge
Copy link

mlbridge bot commented Jun 1, 2020

Webrevs

edvbld
edvbld approved these changes Jun 1, 2020
Copy link
Member

@edvbld edvbld left a comment

Looks good!

@openjdk
Copy link

openjdk bot commented Jun 1, 2020

@rwestberg This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

Handle empty GitLab merge requests

Reviewed-by: ehelin
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

Since the source branch of this PR was last updated there has been 1 commit pushed to the master branch:

  • f4d9b6e: 404: Add a blank line after quoted blocks in TextToMarkdown

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate f4d9b6e87c48c93bf0fcdcf2ac9723a0ae598a0d.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jun 1, 2020
@rwestberg
Copy link
Member Author

rwestberg commented Jun 1, 2020

/integrate

@openjdk openjdk bot closed this Jun 1, 2020
@openjdk openjdk bot added the integrated label Jun 1, 2020
@openjdk
Copy link

openjdk bot commented Jun 1, 2020

@rwestberg The following commits have been pushed to master since your change was applied:

  • f4d9b6e: 404: Add a blank line after quoted blocks in TextToMarkdown

Your commit was automatically rebased without conflicts.

Pushed as commit 6b9b00c.

@openjdk openjdk bot removed ready rfr labels Jun 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants