Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

publish: add flag --follow #638

Closed
wants to merge 1 commit into from
Closed

publish: add flag --follow #638

wants to merge 1 commit into from

Conversation

edvbld
Copy link
Member

@edvbld edvbld commented Jun 4, 2020

Hi all,

please review this patch that adds the --follow switch and the --browser flag to git publish. These flags can be used to automatically open a browser with the link that a remote host replies with in the response to the git push --set-upstream command that git publish runs. The effect is a "poor mans" git pr create for those that can't (or don't want) to have a personal access token on their machine.

For example, running git publish --follow --browser=firefox will open the "Open a pull request" page in Firefox.

Testing:

  • Manual testing of git publish --follow --browser=firefox on Linux x64

Thanks,
Erik


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Reviewers

Download

$ git fetch https://git.openjdk.java.net/skara pull/638/head:pull/638
$ git checkout pull/638

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jun 4, 2020

👋 Welcome back ehelin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Jun 4, 2020

Webrevs

Copy link
Member

@rwestberg rwestberg left a comment

Looks good!

@openjdk
Copy link

@openjdk openjdk bot commented Jun 5, 2020

@edvbld This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

publish: add flag --follow

Reviewed-by: rwestberg
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

There are currently no new commits on the master branch since the last update of the source branch of this PR. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you would like to avoid potential automatic rebasing, specify the current head hash when integrating, like this: /integrate ff0c4d50ba7bc8dbcfbbf35a9f5476e5e28d19a2.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jun 5, 2020
@edvbld
Copy link
Member Author

@edvbld edvbld commented Jun 5, 2020

/integrate

@openjdk openjdk bot closed this Jun 5, 2020
@openjdk openjdk bot added integrated and removed ready labels Jun 5, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Jun 5, 2020

@edvbld
Pushed as commit 68d3dd6.

@openjdk openjdk bot removed the rfr label Jun 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants