Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

forge: support commit comments #639

Closed
wants to merge 2 commits into from
Closed

Conversation

edvbld
Copy link
Member

@edvbld edvbld commented Jun 4, 2020

Hi all,

please review this patch that adds the possibility to add a comment on a particular commit to HostedRepository via the method addCommitComment. To start out with I've only added support for adding a general comment about a whole commit, not a comment for a particular line in a commit.

The comments for a commit can also be listed with the method commitComments.

Testing:

  • Not that much, later patches will build upon the APIs introduced in this patch

Thanks,
Erik


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Reviewers

Download

$ git fetch https://git.openjdk.java.net/skara pull/639/head:pull/639
$ git checkout pull/639

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jun 4, 2020

👋 Welcome back ehelin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Jun 4, 2020

Webrevs

Copy link
Member

@rwestberg rwestberg left a comment

Looks good in general, just had a comment regarding simplifying the API slightly.

@openjdk
Copy link

@openjdk openjdk bot commented Jun 5, 2020

@edvbld This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

forge: support commit comments

Reviewed-by: rwestberg
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

Since the source branch of this PR was last updated there have been 2 commits pushed to the master branch:

  • 69b126b: notify: rename PullRequestIssues to PullRequestState
  • 68d3dd6: publish: add flag --follow

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate 69b126b4089234b3179c7648a949c9bf80bca2b3.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jun 5, 2020
@edvbld
Copy link
Member Author

@edvbld edvbld commented Jun 5, 2020

/integrate

@openjdk openjdk bot closed this Jun 5, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Jun 5, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Jun 5, 2020

@edvbld The following commits have been pushed to master since your change was applied:

  • 69b126b: notify: rename PullRequestIssues to PullRequestState
  • 68d3dd6: publish: add flag --follow

Your commit was automatically rebased without conflicts.

Pushed as commit dd94745.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants