notify: store resulting commit in PullRequestState

[edvbld]

Hi all,

please review this patch that the resulting (integrated) commit from a PR in the PullRequestState. This data will be used in future patches for more easier handling of notifications. Note that all data in the Storage might not have the "commit" field. If that is the case, then the code will lazily populate the "commit" field.

Testing:

• make test on Linux x64

Thanks,
Erik

---

Progress

• Change must not contain extraneous whitespace
• Change must be properly reviewed

Reviewers

• Robin Westberg (rwestberg - Reviewer) ⚠️ Review applies to 4f70c74

Download

$ git fetch https://git.openjdk.java.net/skara pull/641/head:pull/641
$ git checkout pull/641

[bridgekeeper]

👋 Welcome back ehelin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

[mlbridge]

Webrevs

• 01: Full - Incremental (95e3f66)
• 00: Full (4f70c74)

[rwestberg]

Looks good, but may need to add an extra configuration field.

[rwestberg]

The notifier bot may not be running with the same credentials as the commit bot, so this is possibly the wrong user to look for. The other bots (mlbridge, pr) takes a username from the configuration to use for matching comment poster ids.

[openjdk]

@edvbld This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

notify: store resulting commit in PullRequestState

Reviewed-by: rwestberg

• If you would like to add a summary, use the /summary command.
• To credit additional contributors, use the /contributor command.
• To add additional solved issues, use the /issue command.

Since the source branch of this PR was last updated there have been 2 commits pushed to the master branch:

• c11028a: forge: add commitMetadata method to HostedRepository
• dd94745: forge: support commit comments

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate c11028a093e0a2b0f4180d02ffc46ce18b5b1361.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[edvbld]

/integrate

[openjdk]

@edvbld The following commits have been pushed to master since your change was applied:

• c11028a: forge: add commitMetadata method to HostedRepository
• dd94745: forge: support commit comments

Your commit was automatically rebased without conflicts.

Pushed as commit 1d06390.