Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

notify: rename SlackUpdater to SlackNotifier #649

Closed
wants to merge 1 commit into from

Conversation

edvbld
Copy link
Member

@edvbld edvbld commented Jun 10, 2020

Hi all,

please review this refactoring that renames SlackUpdater to SlackNotifier.

Testing:

  • make test passes

Thanks,
Erik


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Reviewers

Download

$ git fetch https://git.openjdk.java.net/skara pull/649/head:pull/649
$ git checkout pull/649

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jun 10, 2020

👋 Welcome back ehelin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Jun 10, 2020

Webrevs

Copy link
Member

@rwestberg rwestberg left a comment

Looks good!

@openjdk
Copy link

@openjdk openjdk bot commented Jun 10, 2020

@edvbld This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

notify: rename SlackUpdater to SlackNotifier

Reviewed-by: rwestberg
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

Since the source branch of this PR was last updated there has been 1 commit pushed to the master branch:

  • 2ff9a38: Allow a WorkItem to return follow-up items

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate 2ff9a38cd3766b48a1bbe6d57b72905ea747789f.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jun 10, 2020
@edvbld
Copy link
Member Author

@edvbld edvbld commented Jun 10, 2020

/integrate

@openjdk openjdk bot closed this Jun 10, 2020
@openjdk openjdk bot added the integrated label Jun 10, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Jun 10, 2020

@edvbld The following commits have been pushed to master since your change was applied:

  • 2ff9a38: Allow a WorkItem to return follow-up items

Your commit was automatically rebased without conflicts.

Pushed as commit d88ec4d.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants