Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

publish: only exit on error #655

Closed
wants to merge 1 commit into from
Closed

Conversation

edvbld
Copy link
Member

@edvbld edvbld commented Jun 11, 2020

Hi all,

please review this small patch that ensures that GitPublish.main only calls System.exit on error. This is needed because GitPrCreate.main calls GitPublish.main, so GitPublish.main cannot unconditionally call System.exit.

Testing:

  • Manual testing of git publish

Thanks,
Erik


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Reviewers

Download

$ git fetch https://git.openjdk.java.net/skara pull/655/head:pull/655
$ git checkout pull/655

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 11, 2020

👋 Welcome back ehelin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

@openjdk openjdk bot added the rfr label Jun 11, 2020
Copy link
Member

@rwestberg rwestberg left a comment

Looks good!

@openjdk
Copy link

openjdk bot commented Jun 11, 2020

@edvbld This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

publish: only exit on error

Reviewed-by: rwestberg
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

Since the source branch of this PR was last updated there has been 1 commit pushed to the master branch:

  • e4fbefa: publish: only exit on error

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate e4fbefaea1e5d2579fb0a3d54bacfca506439ee0.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jun 11, 2020
@edvbld
Copy link
Member Author

edvbld commented Jun 11, 2020

/integrate

@openjdk openjdk bot added the cli label Jun 11, 2020
@openjdk openjdk bot closed this Jun 11, 2020
@openjdk openjdk bot added integrated and removed ready labels Jun 11, 2020
@openjdk
Copy link

openjdk bot commented Jun 11, 2020

@edvbld
Pushed as commit e4fbefa.

@openjdk openjdk bot removed the rfr label Jun 11, 2020
@mlbridge
Copy link

mlbridge bot commented Jun 11, 2020

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants