Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storage: cache deserialized values in FileStorage #656

Closed
wants to merge 1 commit into from

Conversation

edvbld
Copy link
Member

@edvbld edvbld commented Jun 11, 2020

Hi all,

please review this patch that adds caching of the deserialized value to FileStorage. There is no point in deserializing the same String over and over again, the deserialized value will remain the same.

Testing:

  • Added a new unit test
  • make test passes on Linux x64

Thanks,
Erik


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Reviewers

Download

$ git fetch https://git.openjdk.java.net/skara pull/656/head:pull/656
$ git checkout pull/656

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jun 11, 2020

👋 Welcome back ehelin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

@openjdk openjdk bot added the rfr label Jun 11, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Jun 11, 2020

Webrevs

Copy link
Member

@rwestberg rwestberg left a comment

Looks good!

@openjdk
Copy link

@openjdk openjdk bot commented Jun 12, 2020

@edvbld This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

storage: cache deserialized values in FileStorage

Reviewed-by: rwestberg
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

There are currently no new commits on the master branch since the last update of the source branch of this PR. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you would like to avoid potential automatic rebasing, specify the current head hash when integrating, like this: /integrate e4fbefaea1e5d2579fb0a3d54bacfca506439ee0.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jun 12, 2020
@edvbld
Copy link
Member Author

@edvbld edvbld commented Jun 12, 2020

/integrate

@openjdk openjdk bot closed this Jun 12, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Jun 12, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Jun 12, 2020

@edvbld
Pushed as commit 74c4eda.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants