Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

10: Update git-skara update to show changes #658

Closed
wants to merge 1 commit into from

Conversation

edvbld
Copy link
Member

@edvbld edvbld commented Jun 12, 2020

Hi all,

please review this small patch that makes git skara update show the titles of the changes that it fetched.

Testing:

  • Manual testing of git skara update on Linux x64

Thanks,
Erik


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Issue

  • SKARA-10: Update git-skara update to show changes

Reviewers

Download

$ git fetch https://git.openjdk.java.net/skara pull/658/head:pull/658
$ git checkout pull/658

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jun 12, 2020

👋 Welcome back ehelin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Jun 12, 2020

Webrevs

@edvbld
Copy link
Member Author

@edvbld edvbld commented Jun 12, 2020

Thanks for reviewing @rwestberg!

@edvbld
Copy link
Member Author

@edvbld edvbld commented Jun 12, 2020

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Jun 12, 2020

@edvbld Your merge request cannot be fulfilled at this time, as your changes failed the final jcheck:

  • Too few reviewers with at least role reviewer found (have 0, need at least 1)

Copy link
Member

@rwestberg rwestberg left a comment

Looks good!

@openjdk
Copy link

@openjdk openjdk bot commented Jun 12, 2020

@edvbld This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

10: Update git-skara update to show changes

Reviewed-by: rwestberg
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

There are currently no new commits on the master branch since the last update of the source branch of this PR. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you would like to avoid potential automatic rebasing, specify the current head hash when integrating, like this: /integrate 646926f7a8c2eb7575781fef6c4cfcc819ebc282.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jun 12, 2020
@edvbld
Copy link
Member Author

@edvbld edvbld commented Jun 12, 2020

/integrate

@openjdk openjdk bot closed this Jun 12, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Jun 12, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Jun 12, 2020

@edvbld
Pushed as commit 96088f4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants