Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the isReady condition for the notifier #660

Closed
wants to merge 2 commits into from

Conversation

rwestberg
Copy link
Member

@rwestberg rwestberg commented Jun 12, 2020

Hi all,

Please review this change that updates the isReady condition for the notifier. Instead of having this as a configurable option, just use the well-known values.

Best regards,
Robin


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Reviewers

  • Erik Helin (ehelin - Reviewer) ⚠️ Review applies to 8db8ec4

Download

$ git fetch https://git.openjdk.java.net/skara pull/660/head:pull/660
$ git checkout pull/660

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 12, 2020

👋 Welcome back rwestberg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

edvbld
edvbld approved these changes Jun 12, 2020
Copy link
Member

@edvbld edvbld left a comment

Looks good!

@openjdk
Copy link

openjdk bot commented Jun 12, 2020

@rwestberg This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

Update the isReady condition for the notifier

Reviewed-by: ehelin
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

There are currently no new commits on the master branch since the last update of the source branch of this PR. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you would like to avoid potential automatic rebasing, specify the current head hash when integrating, like this: /integrate b6390d829ac011d372b88d89f48f13ddb71642a0.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jun 12, 2020
@@ -70,11 +68,9 @@ public static NotifyBotBuilder newBuilder() {

private boolean isReady(PullRequest pr) {
Copy link
Member

@edvbld edvbld Jun 12, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps rename isOfInterest?

Copy link
Member Author

@rwestberg rwestberg Jun 12, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, sounds reasonable

@rwestberg
Copy link
Member Author

rwestberg commented Jun 12, 2020

/integrate

@openjdk openjdk bot closed this Jun 12, 2020
@openjdk openjdk bot added integrated and removed ready labels Jun 12, 2020
@openjdk
Copy link

openjdk bot commented Jun 12, 2020

@rwestberg
Pushed as commit afa5d0a.

@openjdk openjdk bot removed the rfr label Jun 12, 2020
@mlbridge
Copy link

mlbridge bot commented Jun 12, 2020

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants