Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the new commit comment notifier discoverable #663

Closed
wants to merge 1 commit into from

Conversation

rwestberg
Copy link
Member

@rwestberg rwestberg commented Jun 15, 2020

Hi all,

Please review this small change that ensures that the new commit comment notifier is visible.

Best regards,
Robin


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Reviewers

  • Erik Helin (ehelin - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/skara pull/663/head:pull/663
$ git checkout pull/663

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jun 15, 2020

👋 Welcome back rwestberg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

edvbld
edvbld approved these changes Jun 15, 2020
Copy link
Member

@edvbld edvbld left a comment

Looks good, thanks for fixing!

@openjdk
Copy link

@openjdk openjdk bot commented Jun 15, 2020

@rwestberg This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

Make the new commit comment notifier discoverable

Reviewed-by: ehelin
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

Since the source branch of this PR was last updated there has been 1 commit pushed to the master branch:

  • ed7df80: 410: Update mailing list bridge subject decorations

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate ed7df8030ad22058fdd7acb0c1e78a03f5cc3bd1.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jun 15, 2020
@rwestberg
Copy link
Member Author

@rwestberg rwestberg commented Jun 15, 2020

/integrate

@openjdk openjdk bot closed this Jun 15, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Jun 15, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Jun 15, 2020

@rwestberg The following commits have been pushed to master since your change was applied:

  • ed7df80: 410: Update mailing list bridge subject decorations

Your commit was automatically rebased without conflicts.

Pushed as commit f92cfb5.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Jun 15, 2020

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants