Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

416: Expose committer date in CommitMetadata #664

Closed
wants to merge 1 commit into from

Conversation

edvbld
Copy link
Member

@edvbld edvbld commented Jun 15, 2020

Hi all,

please review this patch that removes the date() method in CommitMetadata and adds authored() and committed(). For Mercurial commits authored() will equal committed() since Mercurial does not support different author and committer dates.

Testing:

  • make test passes on Linux x64
  • Added a new unit test

Thanks,
Erik


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Issue

  • SKARA-416: Expose committer date in CommitMetadata

Reviewers

Download

$ git fetch https://git.openjdk.java.net/skara pull/664/head:pull/664
$ git checkout pull/664

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jun 15, 2020

👋 Welcome back ehelin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

Copy link
Member

@rwestberg rwestberg left a comment

Looks good!

@mlbridge
Copy link

@mlbridge mlbridge bot commented Jun 15, 2020

Webrevs

@openjdk
Copy link

@openjdk openjdk bot commented Jun 15, 2020

@edvbld This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

416: Expose committer date in CommitMetadata

Reviewed-by: rwestberg
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

Since the source branch of this PR was last updated there have been 2 commits pushed to the master branch:

  • f92cfb5: Make the new commit comment notifier discoverable
  • ed7df80: 410: Update mailing list bridge subject decorations

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate f92cfb52220f73b710371be8662339e13c9b7bc2.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jun 15, 2020
@edvbld
Copy link
Member Author

@edvbld edvbld commented Jun 15, 2020

/integrate

@openjdk openjdk bot closed this Jun 15, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Jun 15, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Jun 15, 2020

@edvbld The following commits have been pushed to master since your change was applied:

  • f92cfb5: Make the new commit comment notifier discoverable
  • ed7df80: 410: Update mailing list bridge subject decorations

Your commit was automatically rebased without conflicts.

Pushed as commit 5397abe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants