416: Expose committer date in CommitMetadata #664
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Hi all,
please review this patch that removes the
date()
method inCommitMetadata
and addsauthored()
andcommitted()
. For Mercurial commitsauthored()
will equalcommitted()
since Mercurial does not support different author and committer dates.Testing:
make test
passes on Linux x64Thanks,
Erik
Progress
Issue
Reviewers
Download
$ git fetch https://git.openjdk.java.net/skara pull/664/head:pull/664
$ git checkout pull/664