Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

411: Warn when a PR issue is not of a primary type #665

Closed
wants to merge 2 commits into from

Conversation

edvbld
Copy link
Member

@edvbld edvbld commented Jun 16, 2020

Hi all,

please review this patch that makes it possible the issue types that should be allowed to be referenced from a PR for a repository.

Testing:

  • Added a new unit test
  • make test passes on Linux x64

Thanks,
Erik


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Issues

  • SKARA-411: Warn when a PR issue is not of a primary type
  • SKARA-415: A repository should be configurable to only accept backports

Reviewers

Download

$ git fetch https://git.openjdk.java.net/skara pull/665/head:pull/665
$ git checkout pull/665

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 16, 2020

👋 Welcome back ehelin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

@edvbld
Copy link
Member Author

edvbld commented Jun 16, 2020

/issue add skara-415

@openjdk
Copy link

openjdk bot commented Jun 16, 2020

@edvbld The issue identifier skara-415 is invalid: This PR can only solve issues in the SKARA project.

@edvbld
Copy link
Member Author

edvbld commented Jun 16, 2020

/issue add SKARA-415

@openjdk
Copy link

openjdk bot commented Jun 16, 2020

@edvbld
Adding additional issue to issue list: 415: A repository should be configurable to only accept backports.

@mlbridge
Copy link

mlbridge bot commented Jun 16, 2020

Webrevs

Copy link
Member

@rwestberg rwestberg left a comment

Looks good, just had one minor comment / question.

@@ -118,6 +118,13 @@ public String name() {
if (repo.value().contains("ignorestale")) {
botBuilder.ignoreStaleReviews(repo.value().get("ignorestale").asBoolean());
}
if (repo.value().contains("issuetypes")) {
var types = repo.value().get("issuetypes").asArray()
Copy link
Member

@rwestberg rwestberg Jun 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can just do .stream() directly here, right? At least I tend to do that.. 😃

Copy link
Member Author

@edvbld edvbld Jun 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, yes, will fix!

@openjdk
Copy link

openjdk bot commented Jun 16, 2020

@edvbld This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

411: Warn when a PR issue is not of a primary type
415: A repository should be configurable to only accept backports

Reviewed-by: rwestberg
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

There are currently no new commits on the master branch since the last update of the source branch of this PR. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you would like to avoid potential automatic rebasing, specify the current head hash when integrating, like this: /integrate 5397abe44191249dbd6f87ab0d526c91638c7880.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jun 16, 2020
@edvbld
Copy link
Member Author

edvbld commented Jun 16, 2020

/integrate

@openjdk openjdk bot closed this Jun 16, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Jun 16, 2020
@openjdk
Copy link

openjdk bot commented Jun 16, 2020

@edvbld
Pushed as commit ddb6dc7.

@kevinrushforth
Copy link
Member

kevinrushforth commented Jun 16, 2020

415: A repository should be configurable to only accept backports

Actually, it's quite the opposite: we want to ensure that a backport record is never used as the bug ID. This PR makes the list of issue types configurable, which is good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants