Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

422: Add CLI tool expand issues in commit message #666

Closed
wants to merge 1 commit into from

Conversation

edvbld
Copy link
Member

@edvbld edvbld commented Jun 16, 2020

Hi all,

please review this patch that adds a tiny new CLI tool called git expand. The tool currently only supports one flag, --issues, which can be used to expand JBS issue ids in commit message. For example if a commit HEAD has the message skara-420 and a user runs

$ git expand --issues HEAD

then the commit message will be 420: Expand JBS issues in PR titles. This is useful for contributors not using git pr create (which already does this and more).

Testing:

  • Manual testing of git expand on Linux x64

Thanks,
Erik


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Issue

  • SKARA-422: Add CLI tool expand issues in commit message

Reviewers

Download

$ git fetch https://git.openjdk.java.net/skara pull/666/head:pull/666
$ git checkout pull/666

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 16, 2020

👋 Welcome back ehelin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

@mlbridge
Copy link

mlbridge bot commented Jun 16, 2020

Webrevs

Copy link
Member

@rwestberg rwestberg left a comment

Looks good!

@openjdk
Copy link

openjdk bot commented Jun 16, 2020

@edvbld This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

422: Add CLI tool expand issues in commit message

Reviewed-by: rwestberg
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

Since the source branch of this PR was last updated there has been 1 commit pushed to the master branch:

  • ddb6dc7: 411: Warn when a PR issue is not of a primary type

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate ddb6dc7c5b14c9f9598b7eb2e54bce25df3d84a0.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jun 16, 2020
@edvbld
Copy link
Member Author

edvbld commented Jun 16, 2020

/integrate

@openjdk openjdk bot closed this Jun 16, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Jun 16, 2020
@openjdk
Copy link

openjdk bot commented Jun 16, 2020

@edvbld The following commits have been pushed to master since your change was applied:

  • ddb6dc7: 411: Warn when a PR issue is not of a primary type

Your commit was automatically rebased without conflicts.

Pushed as commit 9af4807.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants