Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

423: Avoid combining messages with different subjects #668

Closed
wants to merge 1 commit into from

Conversation

rwestberg
Copy link
Member

@rwestberg rwestberg commented Jun 17, 2020

Hi all,

Please review this small change that avoids combining mailinglist messages with different subjects, to enure that integration notices are sent separately.

Best regards,
Robin


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Issue

  • SKARA-423: Avoid combining messages with different subjects

Reviewers

  • Erik Helin (ehelin - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/skara pull/668/head:pull/668
$ git checkout pull/668

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jun 17, 2020

👋 Welcome back rwestberg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

edvbld
edvbld approved these changes Jun 17, 2020
Copy link
Member

@edvbld edvbld left a comment

Looks good!

@openjdk
Copy link

@openjdk openjdk bot commented Jun 17, 2020

@rwestberg This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

423: Avoid combining messages with different subjects

Reviewed-by: ehelin
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

Since the source branch of this PR was last updated there has been 1 commit pushed to the master branch:

  • 3431a9e: 427: Allow bridging PR updates to multiple recipients

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate 3431a9e75f1eb4a70461ceb25d84f768d2cb6320.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jun 17, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Jun 17, 2020

Webrevs

@rwestberg
Copy link
Member Author

@rwestberg rwestberg commented Jun 17, 2020

/integrate

@openjdk openjdk bot closed this Jun 17, 2020
@openjdk openjdk bot added integrated and removed ready labels Jun 17, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Jun 17, 2020

@rwestberg The following commits have been pushed to master since your change was applied:

  • 3431a9e: 427: Allow bridging PR updates to multiple recipients

Your commit was automatically rebased without conflicts.

Pushed as commit 1f6b323.

@openjdk openjdk bot removed the rfr label Jun 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants