Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

419: /issue add should allow project names in lower case #669

Closed

Conversation

rwestberg
Copy link
Member

@rwestberg rwestberg commented Jun 17, 2020

Hi all,

Please review this simple change that matches project names without case sensitivity.

Best regards,
Robin


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Issue

  • SKARA-419: /issue add should allow project names in lower case

Reviewers

  • Erik Helin (ehelin - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/skara pull/669/head:pull/669
$ git checkout pull/669

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jun 17, 2020

👋 Welcome back rwestberg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

edvbld
edvbld approved these changes Jun 17, 2020
Copy link
Member

@edvbld edvbld left a comment

Looks good, thanks for fixing!

@openjdk
Copy link

@openjdk openjdk bot commented Jun 17, 2020

@rwestberg This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

419: /issue add should allow project names in lower case

Reviewed-by: ehelin
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

There are currently no new commits on the master branch since the last update of the source branch of this PR. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you would like to avoid potential automatic rebasing, specify the current head hash when integrating, like this: /integrate 1f6b3236baccbcfbb5d6743f9655bbf82cf992ff.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jun 17, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Jun 17, 2020

Webrevs

@rwestberg
Copy link
Member Author

@rwestberg rwestberg commented Jun 17, 2020

/integrate

@openjdk openjdk bot closed this Jun 17, 2020
@openjdk openjdk bot added integrated and removed ready labels Jun 17, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Jun 17, 2020

@rwestberg
Pushed as commit ca39c57.

@openjdk openjdk bot removed the rfr label Jun 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants