Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

420: Expand JBS issues in PR titles #672

Closed
wants to merge 1 commit into from

Conversation

edvbld
Copy link
Member

@edvbld edvbld commented Jun 17, 2020

Hi all,

please review this small patch that automatically expands issue ids in pull request titles to the "id: title" format. For example if a pull request for the skara repository has the title 420, then the pull request title will be automatically set to 420: Expand JBS issues in PR titles. I have been fairly conservative in what we expand, we only expand titles exactly matching PROJECT-ID or ID, i.e. SKARA-420 or 420.

Testing:

  • Added two new unit tests
  • make test passes on Linux x64

Thanks,
Erik


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Issue

Reviewers

Download

$ git fetch https://git.openjdk.java.net/skara pull/672/head:pull/672
$ git checkout pull/672

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jun 17, 2020

👋 Welcome back ehelin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Jun 17, 2020

Webrevs

Copy link
Member

@rwestberg rwestberg left a comment

Looks good! Perhaps it would be nice with a test that checks that non-matching titles aren't expanded, but it looks like it should work correctly. )

@openjdk
Copy link

@openjdk openjdk bot commented Jun 17, 2020

@edvbld This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

420: Expand JBS issues in PR titles

Reviewed-by: rwestberg
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

Since the source branch of this PR was last updated there has been 1 commit pushed to the master branch:

  • 2f4d5a8: forge: use correct endpoints for commits in GitLab

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate 2f4d5a83f9682a4b51e921023ffd57f599c259f7.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jun 17, 2020
@edvbld
Copy link
Member Author

@edvbld edvbld commented Jun 17, 2020

/integrate

@openjdk openjdk bot closed this Jun 17, 2020
@openjdk openjdk bot added integrated and removed ready labels Jun 17, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Jun 17, 2020

@edvbld The following commits have been pushed to master since your change was applied:

  • 2f4d5a8: forge: use correct endpoints for commits in GitLab

Your commit was automatically rebased without conflicts.

Pushed as commit 2c0df39.

@openjdk openjdk bot removed the rfr label Jun 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants