Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

372: Tool support for small/minor/trivial "fast-track" changes. #677

Closed
wants to merge 6 commits into from

Conversation

@rwestberg
Copy link
Member

@rwestberg rwestberg commented Jun 24, 2020

Hi all,

Please review this change that adds the possibility of issuing an /issue create command. The title and the body of the issue will be copied from the pull request. The command is only available for committers and above (who already have access to creating issues manually).

Best regards,
Robin


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Issue

  • SKARA-372: Tool support for small/minor/trivial "fast-track" changes.

Reviewers

  • Erik Helin (ehelin - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/skara pull/677/head:pull/677
$ git checkout pull/677

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jun 24, 2020

👋 Welcome back rwestberg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

@openjdk openjdk bot changed the title 372 372: Tool support for small/minor/trivial "fast-track" changes. Jun 24, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Jun 24, 2020

Webrevs

Copy link
Member

@edvbld edvbld left a comment

Looks good overall, just a few inline comments on how to specify component and subcomponent.

@kevinrushforth
Copy link
Member

@kevinrushforth kevinrushforth commented Jun 24, 2020

The command is only available for committers and above (who already have access to creating issues manually).

An author also has access to create an issue manually (which it looks like what you actually implemented).

Robin Westberg and others added 3 commits Jun 24, 2020
Co-authored-by: Erik Duveblad <erik.helin@oracle.com>
Co-authored-by: Erik Duveblad <erik.helin@oracle.com>
Co-authored-by: Erik Duveblad <erik.helin@oracle.com>
edvbld
edvbld approved these changes Jun 25, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Jun 25, 2020

@rwestberg This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

372: Tool support for small/minor/trivial "fast-track" changes.

Reviewed-by: ehelin
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

Since the source branch of this PR was last updated there has been 1 commit pushed to the master branch:

  • 5b5c3a5: 430: /summary command does not support multi-line summaries

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate 5b5c3a53708e50004e3c46829054e5ea97b1a92c.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jun 25, 2020
@rwestberg
Copy link
Member Author

@rwestberg rwestberg commented Jun 25, 2020

/integrate

@openjdk openjdk bot closed this Jun 25, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Jun 25, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Jun 25, 2020

@rwestberg The following commits have been pushed to master since your change was applied:

  • 5b5c3a5: 430: /summary command does not support multi-line summaries

Your commit was automatically rebased without conflicts.

Pushed as commit 971c746.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants