Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

430: /summary command does not support multi-line summaries #678

Closed
wants to merge 3 commits into from

Conversation

edvbld
Copy link
Member

@edvbld edvbld commented Jun 24, 2020

Hi all,

please review this patch that makes the /summary pull request command accept multi-line summaries. As described on the Skara wiki the /summary command should this, since the commit message format allow for this.

Testing:

  • Added a new unit test
  • make test passes on Linux x64

Thanks,
Erik


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Issue

  • SKARA-430: /summary command does not support multi-line summaries

Reviewers

Download

$ git fetch https://git.openjdk.java.net/skara pull/678/head:pull/678
$ git checkout pull/678

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jun 24, 2020

👋 Welcome back ehelin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

@openjdk openjdk bot changed the title 430 430: /summary command does not support multi-line summaries Jun 24, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Jun 24, 2020

Webrevs

Copy link
Member

@rwestberg rwestberg left a comment

Looks good, I'm a little bit concerned about what happens if we start to support multiple commands per comment, but I guess that can be taken care of at that time.. :)

@openjdk
Copy link

@openjdk openjdk bot commented Jun 24, 2020

@edvbld This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

430: /summary command does not support multi-line summaries

Reviewed-by: rwestberg
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

Since the source branch of this PR was last updated there has been 1 commit pushed to the master branch:

  • 645a73c: 428: git-jcheck does not work on repositories without default or maser branch

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate 645a73cd6d90a3adfc1f722be63e9c9a3f90e540.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jun 24, 2020
edvbld and others added 2 commits Jun 24, 2020
Co-authored-by: Robin Westberg <robin@westberg.se>
- Handle preceeding empty lines
- Handle trailing empty lines
- Show error when command is used for both single- and multi-line
  summaries
@edvbld
Copy link
Member Author

@edvbld edvbld commented Jun 25, 2020

/integrate

@openjdk openjdk bot closed this Jun 25, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Jun 25, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Jun 25, 2020

@edvbld The following commits have been pushed to master since your change was applied:

  • 645a73c: 428: git-jcheck does not work on repositories without default or maser branch

Your commit was automatically rebased without conflicts.

Pushed as commit 5b5c3a5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants