Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add info about MANPATH to README #680

Closed
wants to merge 3 commits into from

Conversation

magicus
Copy link
Member

@magicus magicus commented Jun 26, 2020

Add info about MANPATH to README.


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Reviewers

  • Erik Helin (ehelin - Reviewer) ⚠️ Review applies to 105721f

Download

$ git fetch https://git.openjdk.java.net/skara pull/680/head:pull/680
$ git checkout pull/680

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jun 26, 2020

👋 Welcome back ihse! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

@openjdk openjdk bot added the rfr label Jun 26, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Jun 26, 2020

Webrevs

@edvbld
Copy link
Member

@edvbld edvbld commented Jun 29, 2020

Thanks @magicus!

Just a very minor nit - the custom is to not end pull request titles with a period (just like we don't end commit message titles with a period). You can edit the title of this pull request by either clicking the "Edit" button in a browser or if you are using the Skara CLI tools: git pr set --title.

README.md Outdated Show resolved Hide resolved
edvbld
edvbld approved these changes Jun 29, 2020
Copy link
Member

@edvbld edvbld left a comment

Looks good, just a minor comment inline.

@openjdk
Copy link

@openjdk openjdk bot commented Jun 29, 2020

@magicus This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

Add info about MANPATH to README

Reviewed-by: ehelin
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

Since the source branch of this PR was last updated there have been 44 commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate 38d782ad6b2d00b9860a9ce434e1240bdc4148fd.

As you do not have Committer status in this project, an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@edvbld) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready label Jun 29, 2020
Co-authored-by: Erik Duveblad <erik.helin@oracle.com>
@magicus
Copy link
Member Author

@magicus magicus commented Jun 29, 2020

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Jun 29, 2020

@magicus
Your change (at version c443e8e) is now ready to be sponsored by a Committer.

@openjdk openjdk bot added the sponsor label Jun 29, 2020
@magicus magicus changed the title Add info about MANPATH to README. Add info about MANPATH to README Jun 29, 2020
@edvbld
Copy link
Member

@edvbld edvbld commented Jun 29, 2020

/sponsor

@openjdk
Copy link

@openjdk openjdk bot commented Jun 29, 2020

@edvbld @magicus The following commits have been pushed to master since your change was applied:

  • 38d782a: Add support for paginated fields
  • 8f94a62: 342: Pull request bot should warn on merge commits with non-target branch parent
  • 971c746: 372: Tool support for small/minor/trivial "fast-track" changes.
  • 5b5c3a5: 430: /summary command does not support multi-line summaries
  • 645a73c: 428: git-jcheck does not work on repositories without default or maser branch
  • 7f84ac8: vcs: proper source paths for merge commits
  • 9f5bf30: webrev: add logging
  • c817a8f: Fix typo in property name for GitLab commitMetadata
  • 2c0df39: 420: Expand JBS issues in PR titles
  • 2f4d5a8: forge: use correct endpoints for commits in GitLab
  • 28456f5: vcs: handle lightweight tags in Git
  • ca39c57: 419: /issue add should allow project names in lower case
  • 1f6b323: 423: Avoid combining messages with different subjects
  • 3431a9e: 427: Allow bridging PR updates to multiple recipients
  • 9af4807: 422: Add CLI tool expand issues in commit message
  • ddb6dc7: 411: Warn when a PR issue is not of a primary type
  • 5397abe: 416: Expose committer date in CommitMetadata
  • f92cfb5: Make the new commit comment notifier discoverable
  • ed7df80: 410: Update mailing list bridge subject decorations
  • f89126d: forge: use commit object in GitHubRepository.commitMetadata
  • afa5d0a: Update the isReady condition for the notifier
  • b6390d8: Ensure that the notifier looks at both open and closed PRs
  • 96088f4: 10: Update git-skara update to show changes
  • 646926f: Upgrade the notifier database lazily
  • 74c4eda: storage: cache deserialized values in FileStorage
  • e4fbefa: publish: only exit on error
  • 1b654ad: 98: Testing of bot configuration parsing
  • 08c0273: notifier: add commit comment notifier
  • 88adf50: notify: prefix event handlers with "on*"
  • 66b93ca: notify: create test utils
  • c0203e0: notify: use "listener" instead of "consumer"/"updater" in names
  • 6f35af3: notify: rename IssueUpdater to IssueNotifier
  • d88ec4d: notify: rename SlackUpdater to SlackNotifier
  • 2ff9a38: Allow a WorkItem to return follow-up items
  • a0d76c5: notify: rename JsonUpdater to JsonNotifier
  • 99c40da: notify: rename MailingListUpdater to MailingListNotifier
  • 0878fd3: 329: Add /cc command
  • e601083: notify: add handleIntegratedPullRequest callback
  • 1d06390: notify: store resulting commit in PullRequestState
  • c11028a: forge: add commitMetadata method to HostedRepository
  • dd94745: forge: support commit comments
  • 69b126b: notify: rename PullRequestIssues to PullRequestState
  • 68d3dd6: publish: add flag --follow
  • ff0c4d5: webrev: proper index.html fix and charset fixes

Your commit was automatically rebased without conflicts.

Pushed as commit 0d45135.

@magicus magicus deleted the ihse-readme-manpages branch Jun 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants