Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

330: Allow commands at end of PR body #682

Closed
wants to merge 7 commits into from

Conversation

rwestberg
Copy link
Member

@rwestberg rwestberg commented Jun 29, 2020

Hi all,

Please review this change that allows commands in the PR body. It also adds support for multiple commands in a single comment, and centralizes the multiline command handling.

Best regards,
Robin


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Issue

  • SKARA-330: Allow commands at end of PR body

Reviewers

  • Erik Helin (ehelin - Reviewer) ⚠️ Review applies to fb8119d

Download

$ git fetch https://git.openjdk.java.net/skara pull/682/head:pull/682
$ git checkout pull/682

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jun 29, 2020

👋 Welcome back rwestberg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

@openjdk openjdk bot changed the title 330 330: Allow commands at end of PR body Jun 29, 2020
edvbld
edvbld approved these changes Jun 29, 2020
Copy link
Member

@edvbld edvbld left a comment

Super nice work Robin! 🚀 🥳 Really liked that you enabled multiple commands per comment as well, seems generally useful. See inline for a very minor nit on formatting.

@openjdk
Copy link

@openjdk openjdk bot commented Jun 29, 2020

@rwestberg This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

330: Allow commands at end of PR body

Reviewed-by: ehelin
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

Since the source branch of this PR was last updated there have been 3 commits pushed to the master branch:

  • 0d45135: Add info about MANPATH to README
  • 38d782a: Add support for paginated fields
  • 8f94a62: 342: Pull request bot should warn on merge commits with non-target branch parent

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate 0d451355fdc74380061153daf248bb45cbb55b3b.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jun 29, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Jun 29, 2020

Webrevs

….java

Co-authored-by: Erik Duveblad <erik.helin@oracle.com>
@rwestberg
Copy link
Member Author

@rwestberg rwestberg commented Jun 29, 2020

/integrate

@openjdk openjdk bot closed this Jun 29, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Jun 29, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Jun 29, 2020

@rwestberg The following commits have been pushed to master since your change was applied:

  • 0d45135: Add info about MANPATH to README
  • 38d782a: Add support for paginated fields
  • 8f94a62: 342: Pull request bot should warn on merge commits with non-target branch parent

Your commit was automatically rebased without conflicts.

Pushed as commit 95d655d.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants