Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

442: Remove debug logging #686

Closed
wants to merge 1 commit into from
Closed

Conversation

rwestberg
Copy link
Member

@rwestberg rwestberg commented Jul 2, 2020

Remove the stacktrace log for a caught exception that is expected, and just clutters the log.


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Issue

Reviewers

  • Erik Helin (ehelin - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/skara pull/686/head:pull/686
$ git checkout pull/686

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jul 2, 2020

👋 Welcome back rwestberg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

@openjdk openjdk bot added the rfr label Jul 2, 2020
@rwestberg
Copy link
Member Author

@rwestberg rwestberg commented Jul 2, 2020

/issue create libs

@openjdk
Copy link

@openjdk openjdk bot commented Jul 2, 2020

@rwestberg An error occurred when attempting to create an issue: Unknown component libs. Known components are cli, bots, libraries, associate.

@rwestberg
Copy link
Member Author

@rwestberg rwestberg commented Jul 2, 2020

/issue create libraries

@openjdk
Copy link

@openjdk openjdk bot commented Jul 2, 2020

@rwestberg An error occurred when attempting to create an issue: No value present

@rwestberg rwestberg changed the title Remove annoying debug logging 442 Jul 2, 2020
@openjdk openjdk bot changed the title 442 442: Remove debug logging Jul 2, 2020
@rwestberg
Copy link
Member Author

@rwestberg rwestberg commented Jul 2, 2020

/reviewer add @edvbld

@openjdk
Copy link

@openjdk openjdk bot commented Jul 2, 2020

@rwestberg
Reviewer ehelin successfully added.

@openjdk
Copy link

@openjdk openjdk bot commented Jul 2, 2020

@rwestberg This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

442: Remove debug logging

Reviewed-by: ehelin
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

There are currently no new commits on the master branch since the last update of the source branch of this PR. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you would like to avoid potential automatic rebasing, specify the current head hash when integrating, like this: /integrate 50366a1ff48a5f762c20090def62d9bace6a085d.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jul 2, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Jul 2, 2020

@rwestberg This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

442: Remove debug logging

Reviewed-by: ehelin
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

There are currently no new commits on the master branch since the last update of the source branch of this PR. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you would like to avoid potential automatic rebasing, specify the current head hash when integrating, like this: /integrate 50366a1ff48a5f762c20090def62d9bace6a085d.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@rwestberg
Copy link
Member Author

@rwestberg rwestberg commented Jul 2, 2020

Erik approved this one-liner offline.

edvbld
edvbld approved these changes Jul 2, 2020
Copy link
Member

@edvbld edvbld left a comment

Looks good!

@mlbridge
Copy link

@mlbridge mlbridge bot commented Jul 2, 2020

Webrevs

@rwestberg
Copy link
Member Author

@rwestberg rwestberg commented Jul 2, 2020

/integrate

@openjdk openjdk bot closed this Jul 2, 2020
@openjdk openjdk bot added integrated and removed ready labels Jul 2, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Jul 2, 2020

@rwestberg
Pushed as commit dff0ba8.

@openjdk openjdk bot removed the rfr label Jul 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants