New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
443: /reviewer pull request command should accept multiple reviewers #687
Conversation
|
showHelp(pr, reply);; | ||
return; | ||
var reviewers = new ArrayList<Contributor>(); | ||
for (var entry : matcher.group(2).split(" ")) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we allow "," as a separator as well, like the /issue
and /cc
commands?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah that makes sense, let me fix
@edvbld This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type
Since the source branch of this PR was last updated there have been 4 commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge
|
Webrevs
|
/integrate |
@edvbld The following commits have been pushed to master since your change was applied:
Your commit was automatically rebased without conflicts. Pushed as commit a5891a8. |
Hi all,
please review this patch that makes the
/reviewer
pull request command accept multiple reviewers at once.Testing:
make test
passes on Linux x64Thanks,
Erik
Progress
Issue
Reviewers
Download
$ git fetch https://git.openjdk.java.net/skara pull/687/head:pull/687
$ git checkout pull/687