Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

443: /reviewer pull request command should accept multiple reviewers #687

Closed
wants to merge 2 commits into from

Conversation

edvbld
Copy link
Member

@edvbld edvbld commented Jul 2, 2020

Hi all,

please review this patch that makes the /reviewer pull request command accept multiple reviewers at once.

Testing:

  • Added a unit test
  • make test passes on Linux x64

Thanks,
Erik


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Issue

  • SKARA-443: /reviewer pull request command should accept multiple reviewers

Reviewers

Download

$ git fetch https://git.openjdk.java.net/skara pull/687/head:pull/687
$ git checkout pull/687

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jul 2, 2020

👋 Welcome back ehelin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

@openjdk openjdk bot changed the title 443 443: /reviewer pull request command should accept multiple reviewers Jul 2, 2020
Copy link
Member

@rwestberg rwestberg left a comment

Looks good, just one question!

showHelp(pr, reply);;
return;
var reviewers = new ArrayList<Contributor>();
for (var entry : matcher.group(2).split(" ")) {
Copy link
Member

@rwestberg rwestberg Jul 2, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we allow "," as a separator as well, like the /issue and /cc commands?

Copy link
Member Author

@edvbld edvbld Jul 2, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah that makes sense, let me fix 👍

@openjdk
Copy link

@openjdk openjdk bot commented Jul 2, 2020

@edvbld This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

443: /reviewer pull request command should accept multiple reviewers

Reviewed-by: rwestberg
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

Since the source branch of this PR was last updated there have been 4 commits pushed to the master branch:

  • 66d1ba5: 437: Skara should invalidate approved reviews if the target branch changes
  • c0434d5: 445: The issue notifier should not process commits for downstream projects
  • dff0ba8: 442: Remove debug logging
  • 50366a1: 441: Proper backport support

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate 66d1ba5f7e33cbb9ae3416d9fb87fe2714a0755e.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jul 2, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Jul 2, 2020

Webrevs

@edvbld
Copy link
Member Author

@edvbld edvbld commented Jul 3, 2020

/integrate

@openjdk openjdk bot closed this Jul 3, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Jul 3, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Jul 3, 2020

@edvbld The following commits have been pushed to master since your change was applied:

  • 66d1ba5: 437: Skara should invalidate approved reviews if the target branch changes
  • c0434d5: 445: The issue notifier should not process commits for downstream projects
  • dff0ba8: 442: Remove debug logging
  • 50366a1: 441: Proper backport support

Your commit was automatically rebased without conflicts.

Pushed as commit a5891a8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants