Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

437: Skara should invalidate approved reviews if the target branch changes #689

Closed
wants to merge 1 commit into from

Conversation

rwestberg
Copy link
Member

@rwestberg rwestberg commented Jul 3, 2020

Hi all,

Please review this change that disregards pull request reviews done before changing the target branch, as that is not what's reviewed. Tested manually on GitHub.

Best regards,
Robin


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Issue

  • SKARA-437: Skara should invalidate approved reviews if the target branch changes

Reviewers

  • Erik Helin (ehelin - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/skara pull/689/head:pull/689
$ git checkout pull/689

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jul 3, 2020

👋 Welcome back rwestberg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

@openjdk openjdk bot changed the title 437 437: Skara should invalidate approved reviews if the target branch changes Jul 3, 2020
@openjdk openjdk bot added the rfr label Jul 3, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Jul 3, 2020

Webrevs

edvbld
edvbld approved these changes Jul 3, 2020
Copy link
Member

@edvbld edvbld left a comment

Looks good!

@openjdk
Copy link

@openjdk openjdk bot commented Jul 3, 2020

@rwestberg This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

437: Skara should invalidate approved reviews if the target branch changes

Reviewed-by: ehelin
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

There are currently no new commits on the master branch since the last update of the source branch of this PR. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you would like to avoid potential automatic rebasing, specify the current head hash when integrating, like this: /integrate c0434d51ae21fa24da85b923f0cde83ea886d8bb.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jul 3, 2020
@rwestberg
Copy link
Member Author

@rwestberg rwestberg commented Jul 3, 2020

/integrate

@openjdk openjdk bot closed this Jul 3, 2020
@openjdk openjdk bot added integrated and removed ready labels Jul 3, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Jul 3, 2020

@rwestberg
Pushed as commit 66d1ba5.

@openjdk openjdk bot removed the rfr label Jul 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants