Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Dockerfile issues #692

Closed
wants to merge 1 commit into from
Closed

Conversation

junyuan-z
Copy link
Contributor

@junyuan-z junyuan-z commented Jul 3, 2020

Hi all,

This PR is trying to fix Dockerfile build issue.

  1. adding deps.env file to Docker build env

error before this change:

Removing intermediate container 72a7b09806df
 ---> 66828863be56
Step 19/52 : COPY gradlew ./
 ---> a3b0c0c94d91
Step 20/52 : ENV JAVA_TOOL_OPTIONS=$JAVA_OPTIONS
 ---> Running in a7296b1bc7c5
Removing intermediate container a7296b1bc7c5
 ---> 9034013f18e5
Step 21/52 : RUN sh gradlew --no-daemon --version $GRADLE_OPTIONS
 ---> Running in 6172925e9a37
gradlew: line 87: ./deps.env: No such file or directory 
  1. update .tar.gz file name

error before this change:

 ---> 550d7ac342a3
Step 46/53 : COPY --from=prerequisites-runtime /bots/git/ /bots/git/
 ---> 6783d09d4559
Step 47/53 : COPY --from=prerequisites-runtime /bots/hg/ /bots/hg/
 ---> e1a17de8e587
Step 48/53 : COPY --from=builder /bots-build/bots/cli/build/distributions/cli-unknown-linux.tar.gz /bots/tar/
COPY failed: stat /var/lib/docker/overlay2/fa560932e1a43ea902ad69deadd9ed76da81c01596e971832cec2906e3c494f0/merged/bots-build/bots/cli/build/distributions/cli-unknown-linux.tar.gz: no such file or directory

Thanks,

Junyuan


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Reviewers

Download

$ git fetch https://git.openjdk.java.net/skara pull/692/head:pull/692
$ git checkout pull/692

1. adding deps.env file to Docker build env
2. update .tar.gz file name
@bridgekeeper bridgekeeper bot added the oca label Jul 3, 2020
@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jul 3, 2020

Hi @junyzheng, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user junyzheng" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

@openjdk openjdk bot added the build label Jul 3, 2020
@junyuan-z
Copy link
Contributor Author

@junyuan-z junyuan-z commented Jul 3, 2020

/covered

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jul 3, 2020

Thank you! Please allow for a few business days to verify that your employer has signed the OCA. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated!

@mlbridge
Copy link

@mlbridge mlbridge bot commented Jul 13, 2020

Webrevs

@junyuan-z
Copy link
Contributor Author

@junyuan-z junyuan-z commented Jul 27, 2020

can I get a review on this one? Thanks!

Copy link
Member

@rwestberg rwestberg left a comment

Looks good, thanks for fixing! Sorry about the delay, it arrived right in the middle of vacation season. :)

@openjdk
Copy link

@openjdk openjdk bot commented Jul 30, 2020

@junyzheng This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

Fix Dockerfile issues

Reviewed-by: rwestberg
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

Since the source branch of this PR was last updated there have been 15 commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate a813417a36bfe3f0c5c28e1a19428921d45569d8.

As you are not a known OpenJDK Author, an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@rwestberg) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready label Jul 30, 2020
@junyuan-z
Copy link
Contributor Author

@junyuan-z junyuan-z commented Jul 30, 2020

/integrate

@openjdk openjdk bot added the sponsor label Jul 30, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Jul 30, 2020

@junyzheng
Your change (at version fcaef94) is now ready to be sponsored by a Committer.

@junyuan-z
Copy link
Contributor Author

@junyuan-z junyuan-z commented Jul 30, 2020

@rwestberg Thank you for reviewing this!

@rwestberg
Copy link
Member

@rwestberg rwestberg commented Jul 30, 2020

/sponsor

@openjdk
Copy link

@openjdk openjdk bot commented Jul 30, 2020

@rwestberg @junyzheng The following commits have been pushed to master since your change was applied:

  • a813417: 461: Do a git version check
  • 233758e: 456: Read value of resolved in build properly when considering backports
  • 7de9db7: git-jcheck: simplify options
  • 40573c7: git-trees: fix usage message
  • 17c058e: forge: use /app/installations/ endpoint for GitHub access tokens
  • bc3e59b: git-pr: add csr sub-command
  • a39fb99: git-pr: add contributor sub-command
  • 9b2c7e0: git-pr: add summary sub-command
  • 45cff81: git-pr: add cc sub-command
  • cb5eb04: args: fix toString() for trailing input
  • ebf319e: git-pr: add reviewer sub-command
  • ef37ead: git-pr: use correct argument in git-pr issue
  • de75785: pr: filter external commands in CommandWorkItem
  • 89cba77: pr: fix merge tests
  • fce40b5: pr: improve message for unexpected merge commits

Your commit was automatically rebased without conflicts.

Pushed as commit 8112650.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants