New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Dockerfile issues #692
Conversation
1. adding deps.env file to Docker build env 2. update .tar.gz file name
Hi @junyzheng, welcome to this OpenJDK project and thanks for contributing! We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user junyzheng" as summary for the issue. If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing |
/covered |
Thank you! Please allow for a few business days to verify that your employer has signed the OCA. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated! |
can I get a review on this one? Thanks! |
Looks good, thanks for fixing! Sorry about the delay, it arrived right in the middle of vacation season. :)
@junyzheng This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type
Since the source branch of this PR was last updated there have been 15 commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge As you are not a known OpenJDK Author, an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@rwestberg) but any other Committer may sponsor as well.
|
/integrate |
@junyzheng |
@rwestberg Thank you for reviewing this! |
/sponsor |
@rwestberg @junyzheng The following commits have been pushed to master since your change was applied:
Your commit was automatically rebased without conflicts. Pushed as commit 8112650. |
Hi all,
This PR is trying to fix Dockerfile build issue.
error before this change:
error before this change:
Thanks,
Junyuan
Progress
Reviewers
Download
$ git fetch https://git.openjdk.java.net/skara pull/692/head:pull/692
$ git checkout pull/692