Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git-pr: add reviewer sub-command #697

wants to merge 1 commit into from


Copy link

@edvbld edvbld commented Jul 8, 2020

Hi all,

please review this patch that adds the git pr reviewer sub-command which corresponds to the /reviewer pull request command. A pull request author can now run git pr reviewr --add=ehelin to mark me as a reviewer of a pull request (note that not all OpenJDK projects allow authors to add reviewers).


  • Manual testing on Linux x64



  • Change must not contain extraneous whitespace
  • Change must be properly reviewed



$ git fetch pull/697/head:pull/697
$ git checkout pull/697

Copy link

@bridgekeeper bridgekeeper bot commented Jul 8, 2020

👋 Welcome back ehelin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

Copy link

@openjdk openjdk bot commented Jul 8, 2020

@edvbld This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

git-pr: add reviewer sub-command

Reviewed-by: jvernee
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

There are currently no new commits on the master branch since the last update of the source branch of this PR. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you would like to avoid potential automatic rebasing, specify the current head hash when integrating, like this: /integrate ef37ead172c2c5edb255a1823888adcaa2d103e9.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jul 8, 2020
Copy link
Member Author

@edvbld edvbld commented Jul 8, 2020


@openjdk openjdk bot closed this Jul 8, 2020
@openjdk openjdk bot added integrated and removed ready labels Jul 8, 2020
Copy link

@openjdk openjdk bot commented Jul 8, 2020

Pushed as commit ebf319e.

@openjdk openjdk bot removed the rfr label Jul 8, 2020
Copy link

@mlbridge mlbridge bot commented Jul 8, 2020


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants