Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git-pr: add cc sub-command #699

Closed
wants to merge 1 commit into from
Closed

git-pr: add cc sub-command #699

wants to merge 1 commit into from

Conversation

edvbld
Copy link
Member

@edvbld edvbld commented Jul 9, 2020

Hi all,

please review this patch that adds the git pr cc sub-command which corresponds to the /cc pull request command. Contributors preferring the command-line can now run for example git pr cc build-dev hotspot-dev.

Testing:

  • Manual testing on Linux x64

Thanks,
Erik


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Reviewers

Download

$ git fetch https://git.openjdk.java.net/skara pull/699/head:pull/699
$ git checkout pull/699

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jul 9, 2020

👋 Welcome back ehelin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Jul 9, 2020

Webrevs

@edvbld
Copy link
Member Author

@edvbld edvbld commented Jul 9, 2020

/summary
Adds the git pr summary sub-command corresponding to the /summary pull
request command.

@openjdk
Copy link

@openjdk openjdk bot commented Jul 9, 2020

@edvbld Setting summary to:

Adds the `git pr summary` sub-command corresponding to the `/summary` pull
request command.

@edvbld
Copy link
Member Author

@edvbld edvbld commented Jul 9, 2020

/summary

@openjdk
Copy link

@openjdk openjdk bot commented Jul 9, 2020

@edvbld Removing existing summary

@openjdk
Copy link

@openjdk openjdk bot commented Jul 9, 2020

@edvbld This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

git-pr: add cc sub-command

Reviewed-by: jvernee
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

Since the source branch of this PR was last updated there has been 1 commit pushed to the master branch:

  • cb5eb04: args: fix toString() for trailing input

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate cb5eb04b56df71d96098d91f9e693c0470a2b10d.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jul 9, 2020
@edvbld
Copy link
Member Author

@edvbld edvbld commented Jul 9, 2020

/cc build

@openjdk openjdk bot added the build label Jul 9, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Jul 9, 2020

@edvbld The build label was successfully added.

@edvbld
Copy link
Member Author

@edvbld edvbld commented Jul 9, 2020

/integrate

@openjdk openjdk bot closed this Jul 9, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Jul 9, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Jul 9, 2020

@edvbld The following commits have been pushed to master since your change was applied:

  • cb5eb04: args: fix toString() for trailing input

Your commit was automatically rebased without conflicts.

Pushed as commit 45cff81.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants