Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git-pr: add contributor sub-command #701

Closed
wants to merge 2 commits into from

Conversation

edvbld
Copy link
Member

@edvbld edvbld commented Jul 9, 2020

Hi all,

please review this patch that adds the git pr contributor sub-command that corresponds to the /contributor pull request command. Contributors who prefer the command line can now add contributors to a pull request, for example git pr contributor --add='@edvbld' or git pr contributor --add=ehelin.

Testing:

  • Manual testing on Linux x64

Thanks,
Erik


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Reviewers

Contributors

  • Jorn Vernee <jvernee@openjdk.org>

Download

$ git fetch https://git.openjdk.java.net/skara pull/701/head:pull/701
$ git checkout pull/701

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jul 9, 2020

👋 Welcome back ehelin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Jul 9, 2020

@edvbld This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

git-pr: add contributor sub-command

Co-authored-by: Jorn Vernee <jvernee@openjdk.org>
Reviewed-by: jvernee
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

There are currently no new commits on the master branch since the last update of the source branch of this PR. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you would like to avoid potential automatic rebasing, specify the current head hash when integrating, like this: /integrate 9b2c7e03afc3c77e8579244a05f4f6925f81f3ca.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jul 9, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Jul 9, 2020

Webrevs

Co-authored-by: Jorn Vernee <JornVernee@users.noreply.github.com>
@edvbld
Copy link
Member Author

@edvbld edvbld commented Jul 9, 2020

/contributor add jvernee

@openjdk
Copy link

@openjdk openjdk bot commented Jul 9, 2020

@edvbld
Contributor Jorn Vernee <jvernee@openjdk.org> successfully added.

@edvbld
Copy link
Member Author

@edvbld edvbld commented Jul 9, 2020

/integrate

@openjdk openjdk bot closed this Jul 9, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Jul 9, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Jul 9, 2020

@edvbld
Pushed as commit a39fb99.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants