Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

forge: use /app/installations/ endpoint for GitHub access tokens #703

Closed
wants to merge 1 commit into from

Conversation

edvbld
Copy link
Member

@edvbld edvbld commented Jul 10, 2020

Hi all,

please review this small patch that changes the REST endpoint for creating GitHub access tokens from /installations/:installation_id/access_tokens to /app/installations/:installation_id/access_tokens. GitHub announced in April that they are deprecating the /installations/:installation_id/access_tokens endpoint and that applications should migrate to the /app/installations/:installation_id/access_tokens endpoint which features identical semantics.

Thanks,
Erik


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Reviewers

Download

$ git fetch https://git.openjdk.java.net/skara pull/703/head:pull/703
$ git checkout pull/703

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 10, 2020

👋 Welcome back ehelin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

@openjdk openjdk bot added the rfr label Jul 10, 2020
@mlbridge
Copy link

mlbridge bot commented Jul 10, 2020

Webrevs

@openjdk
Copy link

openjdk bot commented Jul 10, 2020

@edvbld This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

forge: use /app/installations/ endpoint for GitHub access tokens

Reviewed-by: jvernee
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

There are currently no new commits on the master branch since the last update of the source branch of this PR. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you would like to avoid potential automatic rebasing, specify the current head hash when integrating, like this: /integrate bc3e59b8622b7a45f6c7980a27cca336b914d79e.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jul 10, 2020
@edvbld
Copy link
Member Author

edvbld commented Jul 10, 2020

/integrate

@openjdk openjdk bot closed this Jul 10, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Jul 10, 2020
@openjdk
Copy link

openjdk bot commented Jul 10, 2020

@edvbld
Pushed as commit 17c058e.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants