Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

456: Read value of resolved in build properly when considering backports #706

Closed
wants to merge 3 commits into from

Conversation

rwestberg
Copy link
Member

@rwestberg rwestberg commented Jul 18, 2020

Hi all,

Please review this small change that makes sure that the JBS custom field "resolved in build" is read properly.

Best regards,
Robin


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Issue

  • SKARA-456: Read value of resolved in build properly when considering backports

Reviewers

  • Erik Helin (ehelin - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/skara pull/706/head:pull/706
$ git checkout pull/706

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jul 18, 2020

👋 Welcome back rwestberg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

@openjdk openjdk bot changed the title 456 456: Read value of resolved in build properly when considering backports Jul 18, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Jul 18, 2020

Webrevs

edvbld
edvbld approved these changes Jul 23, 2020
Copy link
Member

@edvbld edvbld left a comment

Looks good!

@openjdk
Copy link

@openjdk openjdk bot commented Jul 23, 2020

@rwestberg This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

456: Read value of resolved in build properly when considering backports

Reviewed-by: ehelin
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

There are currently no new commits on the master branch since the last update of the source branch of this PR. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you would like to avoid potential automatic rebasing, specify the current head hash when integrating, like this: /integrate 7de9db78a0be731be21607fee5a5a9843a5e243e.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jul 23, 2020
@rwestberg
Copy link
Member Author

@rwestberg rwestberg commented Jul 30, 2020

/integrate

@openjdk openjdk bot closed this Jul 30, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Jul 30, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Jul 30, 2020

@rwestberg
Pushed as commit 233758e.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants