Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

453: Merge commit not included in notification email #710

Closed
wants to merge 1 commit into from

Conversation

rwestberg
Copy link
Member

@rwestberg rwestberg commented Aug 5, 2020

Hi all,

Please review this change that properly filters out commits brought in through a merge PR when creating a mailing list notification email.

Best regards,
Robin


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Issue

  • SKARA-453: Merge commit not included in notification email

Reviewers

  • Erik Helin (ehelin - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/skara pull/710/head:pull/710
$ git checkout pull/710

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 5, 2020

👋 Welcome back rwestberg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

@openjdk openjdk bot changed the title 453 453: Merge commit not included in notification email Aug 5, 2020
@mlbridge
Copy link

mlbridge bot commented Aug 5, 2020

Webrevs

edvbld
edvbld approved these changes Aug 5, 2020
Copy link
Member

@edvbld edvbld left a comment

Looks good!

@openjdk
Copy link

openjdk bot commented Aug 5, 2020

@rwestberg This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

453: Merge commit not included in notification email

Reviewed-by: ehelin
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

Since the source branch of this PR was last updated there has been 1 commit pushed to the master branch:

  • 68d7387: 467: git pr create assumes .jcheck/conf file

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate 68d7387adee14cebf7a803b7cec384244447e780.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Aug 5, 2020
@rwestberg
Copy link
Member Author

rwestberg commented Aug 6, 2020

/integrate

@openjdk openjdk bot closed this Aug 6, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Aug 6, 2020
@openjdk
Copy link

openjdk bot commented Aug 6, 2020

@rwestberg The following commits have been pushed to master since your change was applied:

  • 68d7387: 467: git pr create assumes .jcheck/conf file

Your commit was automatically rebased without conflicts.

Pushed as commit c7890d6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants