Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

467: git pr create assumes .jcheck/conf file #711

wants to merge 1 commit into from


Copy link

@edvbld edvbld commented Aug 5, 2020

Hi all,

please review this patch that makes git pr create work for repositories without an .jcheck/conf file.



  • Change must not contain extraneous whitespace
  • Change must be properly reviewed


  • SKARA-467: git pr create assumes .jcheck/conf file



$ git fetch pull/711/head:pull/711
$ git checkout pull/711

Copy link

bridgekeeper bot commented Aug 5, 2020

👋 Welcome back ehelin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

@openjdk openjdk bot changed the title skara-467 467: git pr create assumes .jcheck/conf file Aug 5, 2020
Copy link

mlbridge bot commented Aug 5, 2020


Copy link

@rwestberg rwestberg left a comment

Looks good!

Copy link

openjdk bot commented Aug 6, 2020

@edvbld This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

467: git pr create assumes .jcheck/conf file

Reviewed-by: rwestberg
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

There are currently no new commits on the master branch since the last update of the source branch of this PR. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you would like to avoid potential automatic rebasing, specify the current head hash when integrating, like this: /integrate 5bf7aac5f37e79987446421fd67576514429923f.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Aug 6, 2020
Copy link
Member Author

edvbld commented Aug 6, 2020


@openjdk openjdk bot closed this Aug 6, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Aug 6, 2020
Copy link

openjdk bot commented Aug 6, 2020

Pushed as commit 68d7387.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants