vcs: lower rename detection to 90% #714
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Hi all,
please review this small patch that lowers rename and copy detection for
GitRepository
to90%
. The default value of50%
is too small for most OpenJDK patches given that the copyright + license header can easily be 19 lines.99%
turned out to be a bit too strict for generating good looking webrevs, so lets take it down to90%
and see how it goes.Testing:
make test
passes on Linux x64Thanks,
Erik
Progress
Reviewers
Download
$ git fetch https://git.openjdk.java.net/skara pull/714/head:pull/714
$ git checkout pull/714