Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vcs: lower rename detection to 90% #714

wants to merge 1 commit into from


Copy link

@edvbld edvbld commented Aug 14, 2020

Hi all,

please review this small patch that lowers rename and copy detection for GitRepository to 90%. The default value of 50% is too small for most OpenJDK patches given that the copyright + license header can easily be 19 lines. 99% turned out to be a bit too strict for generating good looking webrevs, so lets take it down to 90% and see how it goes.


  • make test passes on Linux x64



  • Change must not contain extraneous whitespace
  • Change must be properly reviewed



$ git fetch pull/714/head:pull/714
$ git checkout pull/714

Copy link

@bridgekeeper bridgekeeper bot commented Aug 14, 2020

👋 Welcome back ehelin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

@openjdk openjdk bot added the rfr label Aug 14, 2020
Copy link

@mlbridge mlbridge bot commented Aug 14, 2020


Copy link

@rwestberg rwestberg left a comment

Sounds good!

Copy link

@openjdk openjdk bot commented Aug 14, 2020

@edvbld This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

vcs: lower rename detection to 90%

Reviewed-by: rwestberg
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

Since the source branch of this PR was last updated there has been 1 commit pushed to the master branch:

  • 0cd25fd: webrev: refactor webrev stats

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate 0cd25fd0037bd338b3637e886135fc5eb4b23f0e.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Aug 14, 2020
Copy link
Member Author

@edvbld edvbld commented Aug 15, 2020


@openjdk openjdk bot closed this Aug 15, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Aug 15, 2020
Copy link

@openjdk openjdk bot commented Aug 15, 2020

@edvbld The following commits have been pushed to master since your change was applied:

  • 0cd25fd: webrev: refactor webrev stats

Your commit was automatically rebased without conflicts.

Pushed as commit 49868fe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants