Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git-webrev: add flags --base and --head #716

Closed
wants to merge 2 commits into from

Conversation

edvbld
Copy link
Member

@edvbld edvbld commented Aug 15, 2020

Hi all,

please review this patch that adds two new flags to git-webrev - --base and --head. The flag --base behaves like -r, --rev, that is determines the base commit to compare against. The flag --head determines the commit to use a HEAD for the comparison, that is the most recent commit for the comparison. The two flags --base and --head allows a user to create a webrev between two arbitrary commits (without forcing to check out the head commit first).

Testing:

  • Manual testing on Linux x64

Thanks,
Erik


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Reviewers

Download

$ git fetch https://git.openjdk.java.net/skara pull/716/head:pull/716
$ git checkout pull/716

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Aug 15, 2020

👋 Welcome back ehelin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Aug 15, 2020

Webrevs

Copy link
Member

@rwestberg rwestberg left a comment

Looks good!

@openjdk
Copy link

@openjdk openjdk bot commented Aug 15, 2020

@edvbld This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

git-webrev: add flags --base and --head

Reviewed-by: rwestberg
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

There are currently no new commits on the master branch since the last update of the source branch of this PR. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you would like to avoid potential automatic rebasing, specify the current head hash when integrating, like this: /integrate 1aa66a53413ccd4d949cbb816593d2b753b81dc5.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Aug 15, 2020
@edvbld
Copy link
Member Author

@edvbld edvbld commented Aug 15, 2020

/integrate

@openjdk openjdk bot closed this Aug 15, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Aug 15, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Aug 15, 2020

@edvbld
Pushed as commit 0f8ee81.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants