Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bridgekeeper: support multiple close messages #720

Closed
wants to merge 1 commit into from

Conversation

edvbld
Copy link
Member

@edvbld edvbld commented Aug 18, 2020

Hi all,

please review this small patch that allows the bridgekeeper bot to close pull requests with different messages depending on the type of repository.

Testing:

  • make test passes on Linux x64
  • Added an additional unit test

Thanks,
Erik


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Reviewers

Download

$ git fetch https://git.openjdk.java.net/skara pull/720/head:pull/720
$ git checkout pull/720

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Aug 18, 2020

👋 Welcome back ehelin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Aug 18, 2020

Webrevs

Copy link
Member

@rwestberg rwestberg left a comment

Looks good, just one question!

@openjdk
Copy link

@openjdk openjdk bot commented Aug 18, 2020

@edvbld This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

bridgekeeper: support multiple close messages

Reviewed-by: rwestberg
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

Since the source branch of this PR was last updated there has been 1 commit pushed to the master branch:

  • 7103a3f: mlbridge: configure webrev ref explicitly

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate 7103a3f20d07755d315acc6dd6f88d6d4ab3c048.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Aug 18, 2020
@edvbld
Copy link
Member Author

@edvbld edvbld commented Aug 18, 2020

/integrate

@openjdk openjdk bot closed this Aug 18, 2020
@openjdk openjdk bot added integrated and removed ready labels Aug 18, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Aug 18, 2020

@edvbld The following commits have been pushed to master since your change was applied:

  • 7103a3f: mlbridge: configure webrev ref explicitly

Your commit was automatically rebased without conflicts.

Pushed as commit 0a2cf80.

@openjdk openjdk bot removed the rfr label Aug 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants